From: Kalle Valo <kvalo@codeaurora.org>
To: merez@codeaurora.org
Cc: Colin King <colin.king@canonical.com>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] wil6210: fix potential null dereference of ndev before null check
Date: Thu, 29 Mar 2018 07:53:25 +0300 [thread overview]
Message-ID: <87bmf7mqii.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <49ef31bc36217349a4801dc2eba4735c@codeaurora.org> (merez@codeaurora.org's message of "Wed, 28 Mar 2018 20:46:44 +0300")
merez@codeaurora.org writes:
> On 2018-03-28 20:40, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The pointer ndev is being dereferenced before it is being null checked,
>> hence there is a potential null pointer deference. Fix this by only
>> dereferencing ndev after it has been null checked
>>
>> Detected by CoverityScan, CID#1467010 ("Dereference before null check")
>>
>> Fixes: e00243fab84b ("wil6210: infrastructure for multiple virtual
>> interfaces")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
[...]
> Reviewed-by: Maya Erez <merez@codeaurora.org>
Maya, as you are the wil6210 maintainer you can actually use Acked-by
instead of Reviewed-by. Not that it really matters which one you use,
both of them indicate me that you have checked and agree the patch, but
wanted to point out this anyway :)
--
Kalle Valo
next prev parent reply other threads:[~2018-03-29 4:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 17:40 [PATCH][next] wil6210: fix potential null dereference of ndev before null check Colin King
2018-03-28 17:46 ` merez
2018-03-29 4:53 ` Kalle Valo [this message]
2018-04-10 14:30 ` [next] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmf7mqii.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=wil6210@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).