From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Marty Faltesek <mfaltesek@google.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: cache calibration data when the core is stopped.
Date: Mon, 3 Oct 2016 07:51:45 +0000 [thread overview]
Message-ID: <87bmz1swdr.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1473801118-103112-1-git-send-email-mfaltesek@google.com> (Marty Faltesek's message of "Tue, 13 Sep 2016 17:11:58 -0400")
Marty Faltesek <mfaltesek@google.com> writes:
> Caching calibration data allows it to be accessed when the
> device is not active.
>
> Signed-off-by: Marty Faltesek <mfaltesek@google.com>
[...]
> +int
> +ath10k_cal_data_alloc(struct ath10k *ar, void **buf)
> +{
[...]
> + ath10k_cal_data_alloc(ar, &ar->cal_data);
[...]
> + ret =3D ath10k_cal_data_alloc(ar, &file->private_data);
Pointer to pointer parameters can be a source of problems and if we
could use one shared buffer for both of these cases when it would
simplify the code and we would need the buf parameter at all.
--=20
Kalle Valo=
next prev parent reply other threads:[~2016-10-03 7:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 21:11 [PATCH] ath10k: cache calibration data when the core is stopped Marty Faltesek
2016-10-03 7:46 ` Valo, Kalle
2016-10-05 16:39 ` Marty Faltesek
2016-10-06 7:40 ` Valo, Kalle
2016-10-06 20:29 ` Marty Faltesek
2016-10-03 7:51 ` Valo, Kalle [this message]
2016-10-03 8:02 ` Michal Kazior
2016-10-05 16:40 ` Marty Faltesek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmz1swdr.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mfaltesek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox