From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "bartosz.markowski@tieto.com" <bartosz.markowski@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] ath10k: add platform regulatory domain support
Date: Mon, 12 Sep 2016 15:35:30 +0000 [thread overview]
Message-ID: <87bmztm8qm.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1470140454-3899-3-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Tue, 2 Aug 2016 14:20:54 +0200")
Bartosz Markowski <bartosz.markowski@tieto.com> writes:
> This overrides whatever regulatory the device
> EEPROM contains and uses what the platform says
> instead - in this implementation the ACPI driver.
>
> In case the hint is not programmed or corrupted (0xffff)
> the device falls back to the eeprom programmed settings.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
[...]
> +#ifdef CONFIG_ACPI
> +#define WRD_METHOD "WRDD"
> +#define WRDD_WIFI (0x07)
> +
> +static u32 ath10k_mac_wrdd_get_mcc(struct ath10k *ar, union acpi_object =
*wrdd)
> +{
I don't think the ifdef is really necessary, acpi.h should handle that
(hopefully). Also I changed the error handling to use standard error
values and changed the info messages to dbg, they are too spammy in my
opinion. Please check carefully my changes in the pending branch:
https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=3Dpend=
ing&id=3Dfe91745381ec3999d8de6dedb07b396c82539717
--=20
Kalle Valo=
next prev parent reply other threads:[~2016-09-12 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 12:20 [PATCH 0/2] platform regulatory support Bartosz Markowski
2016-08-02 12:20 ` [PATCH 1/2] ath: export alpha2 helper Bartosz Markowski
2016-10-04 15:02 ` [1/2] " Kalle Valo
2016-08-02 12:20 ` [PATCH 2/2] ath10k: add platform regulatory domain support Bartosz Markowski
2016-09-12 15:35 ` Valo, Kalle [this message]
2016-09-13 13:57 ` Bartosz Markowski
2016-09-14 7:06 ` Valo, Kalle
2016-10-03 7:43 ` Bartosz Markowski
2016-10-03 7:52 ` Valo, Kalle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmztm8qm.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=bartosz.markowski@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox