From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Dave Taht <dave.taht@gmail.com>
Cc: Felix Fietkau <nbd@nbd.name>,
linux-wireless <linux-wireless@vger.kernel.org>,
Michal Kazior <michal.kazior@tieto.com>
Subject: Re: TCP performance regression in mac80211 triggered by the fq code
Date: Tue, 12 Jul 2016 14:57:28 +0200 [thread overview]
Message-ID: <87bn23ui87.fsf@toke.dk> (raw)
In-Reply-To: <CAA93jw6z53P+JCPsjYD-vaY+9vq9ZO-Ob_cXm0AE76uVcM=F9g@mail.gmail.com> (Dave Taht's message of "Tue, 12 Jul 2016 14:44:05 +0200")
Dave Taht <dave.taht@gmail.com> writes:
>> As for why this would happen... There could be a bug in the dequeue code
>> somewhere, but since you get better performance from sticking everything
>> into one queue, my best guess would be that the client is choking on the
>> interleaved packets? I.e. expending more CPU when it can't stick
>> subsequent packets into the same TCP flow?
>
> I share this concern.
>
> The quantum is? I am not opposed to a larger quantum (2 full size
> packets = 3028 in this case?).
The quantum is hard-coded to 300 bytes in the current implementation
(see net/fq_impl.h).
-Toke
next prev parent reply other threads:[~2016-07-12 12:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 10:09 TCP performance regression in mac80211 triggered by the fq code Felix Fietkau
2016-07-12 12:13 ` Dave Taht
2016-07-12 13:21 ` Felix Fietkau
2016-07-12 14:02 ` Dave Taht
2016-07-13 7:57 ` Dave Taht
2016-07-13 8:53 ` Felix Fietkau
2016-07-13 9:13 ` Dave Taht
2016-07-19 13:10 ` Michal Kazior
2016-07-12 12:28 ` Toke Høiland-Jørgensen
2016-07-12 12:44 ` Dave Taht
2016-07-12 12:57 ` Toke Høiland-Jørgensen [this message]
2016-07-12 13:03 ` Dave Taht
2016-07-12 13:22 ` Felix Fietkau
2016-07-12 13:23 ` Felix Fietkau
2016-07-18 21:49 ` Toke Høiland-Jørgensen
2016-07-18 22:02 ` Dave Taht
2016-07-19 13:13 ` Michal Kazior
2016-07-19 14:32 ` Felix Fietkau
2016-07-20 14:45 ` Toke Høiland-Jørgensen
2016-07-20 15:24 ` Toke Høiland-Jørgensen
2016-07-25 5:15 ` Michal Kazior
2016-07-27 17:31 ` Toke Høiland-Jørgensen
2016-07-22 10:51 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn23ui87.fsf@toke.dk \
--to=toke@toke.dk \
--cc=dave.taht@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).