From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "miaoqing@codeaurora.org" <miaoqing@codeaurora.org>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
ath9k-devel <ath9k-devel@qca.qualcomm.com>
Subject: Re: [PATCH v2 2/8] ath9k: make GPIO API to support both of WMAC and SOC
Date: Tue, 1 Mar 2016 12:58:02 +0000 [thread overview]
Message-ID: <87bn6y73tz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1456813784-21218-3-git-send-email-miaoqing@codeaurora.org> (miaoqing@codeaurora.org's message of "Tue, 1 Mar 2016 14:29:38 +0800")
<miaoqing@codeaurora.org> writes:
> From: Miaoqing Pan <miaoqing@codeaurora.org>
>
> commit 61b559dea40e ("ath9k: add extra GPIO led support")
> added ath9k to support access SOC's GPIOs, but implemented
> in a separated API: ath9k_hw_request_gpio().
>
> So this patch make the APIs more common, to support both
> of WMAC and SOC GPIOs. The new APIs as below,
>
> void ath9k_hw_gpio_request_in();
> void ath9k_hw_gpio_request_out();
> void ath9k_hw_gpio_free();
>
> NOTE, the BSP of the SOC chips(AR9340, AR9531, AR9550, AR9561)
> should set the corresponding MUX registers correctly.
>
> Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
>
> Notes:
> v2: fix build warning
> ---
The changelog needs to be after "---" line, or even better if it's in
the cover letter.
--
Kalle Valo
next prev parent reply other threads:[~2016-03-01 12:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 6:29 [PATCH v2 0/8] ath9k GPIO & BT-Coex bug fixes miaoqing
2016-03-01 6:29 ` [PATCH v2 1/8] ath9k: define correct GPIO numbers and bits mask miaoqing
2016-03-01 6:29 ` [PATCH v2 2/8] ath9k: make GPIO API to support both of WMAC and SOC miaoqing
2016-03-01 12:58 ` Valo, Kalle [this message]
2016-03-01 6:29 ` [PATCH v2 3/8] ath9k: free GPIO resource for SOC GPIOs miaoqing
2016-03-01 6:29 ` [PATCH v2 4/8] ath9k: cleanup led_pin initial miaoqing
2016-03-01 6:29 ` [PATCH v2 5/8] ath9k: Allow platform override BTCoex pin miaoqing
2016-03-01 6:29 ` [PATCH v2 6/8] ath9k: add bits definition of BTCoex MODE2/3 for SOC chips miaoqing
2016-03-01 6:29 ` [PATCH v2 7/8] ath9k: fix BTCoex access invalid registers " miaoqing
2016-03-01 6:29 ` [PATCH v2 8/8] ath9k: fix BTCoex configuration " miaoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn6y73tz.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=miaoqing@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).