* [PATCH V3] rtlwifi: rtl8192c: Add init codes for "fw_version" and "fw_subversion".
@ 2015-06-17 14:56 Taehee Yoo
2015-07-20 15:43 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Taehee Yoo @ 2015-06-17 14:56 UTC (permalink / raw)
To: Larry.Finger; +Cc: ap420073, linux-wireless
The variable "fw_version" is used in the _ResetDigitalProcedure1().
but It is not initialized. so I add init codes for "fw_version" and
"fw_subversion".
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
V3 - Fix sparse warning.
V2 - Moved new statements into location where header is known to exist.
drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c
index 29983bc..0142070 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c
@@ -240,6 +240,8 @@ int rtl92c_download_fw(struct ieee80211_hw *hw)
pfwheader->version, pfwheader->signature,
(int)sizeof(struct rtl92c_firmware_header));
+ rtlhal->fw_version = le16_to_cpu(pfwheader->version);
+ rtlhal->fw_subversion = pfwheader->subversion;
pfwdata = pfwdata + sizeof(struct rtl92c_firmware_header);
fwsize = fwsize - sizeof(struct rtl92c_firmware_header);
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V3] rtlwifi: rtl8192c: Add init codes for "fw_version" and "fw_subversion".
2015-06-17 14:56 [PATCH V3] rtlwifi: rtl8192c: Add init codes for "fw_version" and "fw_subversion" Taehee Yoo
@ 2015-07-20 15:43 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2015-07-20 15:43 UTC (permalink / raw)
To: Taehee Yoo; +Cc: Larry.Finger, linux-wireless
Taehee Yoo <ap420073@gmail.com> writes:
> The variable "fw_version" is used in the _ResetDigitalProcedure1().
> but It is not initialized. so I add init codes for "fw_version" and
> "fw_subversion".
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> ---
> V3 - Fix sparse warning.
> V2 - Moved new statements into location where header is known to exist.
I have already applied v2 and v3 won't apply anymore. What you need to
do is to create a new patch against wireless-drivers-next (on top of v2)
which fixes the sparse warning.
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-20 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-17 14:56 [PATCH V3] rtlwifi: rtl8192c: Add init codes for "fw_version" and "fw_subversion" Taehee Yoo
2015-07-20 15:43 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).