From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
"Michal Kazior" <michal.kazior@tieto.com>
Subject: Re: [PATCH v2] ath10k: fix kernel panic while shutting down AP
Date: Sun, 12 Oct 2014 20:59:15 +0300 [thread overview]
Message-ID: <87bnphb24s.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1412942907-24760-1-git-send-email-rmanohar@qti.qualcomm.com> (Rajkumar Manoharan's message of "Fri, 10 Oct 2014 17:38:27 +0530")
Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> Based on GFP flag given to DMA coherent allocation, the behaviour of
> dma_free_coherent is changed. This behavioural diffrence is noticeable
> in ARM platform. If DMA memory is allocated with GFP_KERNEL, free
> coherent can not be called inside spin lock. This is causing kernel
> crash in ARM platforms. Fix this by changing GFP flag to atomic.
>
> Cc: Michal Kazior <michal.kazior@tieto.com>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Thanks, applied.
I modified the commit log a bit to mention the possible commit causing
this:
commit 82d7aba71541a308bc19e869f7cf7423672dee37
Author: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Date: Fri Oct 10 17:38:27 2014 +0530
ath10k: fix kernel panic while shutting down AP
Based on GFP flag given to DMA coherent allocation, the behaviour of
dma_free_coherent is changed. This behavioural diffrence is noticeable
in ARM platform. If DMA memory is allocated with GFP_KERNEL, free
coherent can not be called inside spin lock. This is causing kernel
crash in ARM platforms. Fix this by changing GFP flag to atomic.
This is most likely a regression from commit 64badcb6d645 ("ath10k: workaround
fw beaconing bug").
Cc: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
--
Kalle Valo
prev parent reply other threads:[~2014-10-12 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 12:08 [PATCH v2] ath10k: fix kernel panic while shutting down AP Rajkumar Manoharan
2014-10-12 17:59 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnphb24s.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).