From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: fix wmi service bitmap debug
Date: Tue, 19 Aug 2014 12:49:40 +0300 [thread overview]
Message-ID: <87bnrgbyh7.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQmTvcLDWeKnRXKnAVh27DGrvk+xgr_9DFmuZ3gA6yedYw@mail.gmail.com> (Michal Kazior's message of "Tue, 19 Aug 2014 09:46:07 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 12 August 2014 09:44, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> The 10.x and main firmware branches have
>>> conflicting WMI service bitmap definitions.
>>>
>>> This also fixes WMI services parsing on big-endian
>>> hosts and changes debugfs output to be more human
>>> friendly.
>>>
>>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>>
>> Thanks, applied.
>
> Your tree has wmi_10x_svc_map() and wmi_main_svc_map() swapped[1][2].
> This results in invalid wmi service mappings.
Doh.
> Did you have a conflict on this patch?
Maybe, I can't really remember anymore. I'm always supposed to mention
about conflicts separately, but maybe I forgot this time? Can you send a
followup patch to fix this, please?
--
Kalle Valo
prev parent reply other threads:[~2014-08-19 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 10:03 [PATCH] ath10k: fix wmi service bitmap debug Michal Kazior
2014-08-02 6:39 ` Kalle Valo
2014-08-02 6:59 ` Joe Perches
2014-08-02 8:02 ` Kalle Valo
2014-08-08 10:11 ` Kalle Valo
2014-08-08 10:24 ` Michal Kazior
2014-08-08 11:13 ` Kalle Valo
2014-08-12 7:44 ` Kalle Valo
2014-08-19 7:46 ` Michal Kazior
2014-08-19 9:49 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnrgbyh7.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).