From: Kalle Valo <kvalo@adurom.com>
To: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Cc: <thomas@fjellstrom.ca>, Larry Finger <Larry.Finger@lwfinger.net>,
<linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>,
<netdev@vger.kernel.org>, <wil6210@qca.qualcomm.com>
Subject: Re: [PATCH] ath: wil6210: Fix build error
Date: Sun, 21 Jul 2013 19:55:34 +0300 [thread overview]
Message-ID: <87bo5vyhrt.fsf@purkki.adurom.net> (raw)
In-Reply-To: <5330916.8NnOO4SNAp@lx-vladimir> (Vladimir Kondratiev's message of "Sun, 21 Jul 2013 18:52:38 +0300")
(Dropping stable)
Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> writes:
>> It also looked like that that driver or section of the kernel was compiling
>> with -Werror. I haven't verrified that but I remember seeing "treating all
>> warnings as errors" at one point.
>>
> You are right, I have this in Makefile:
> (if one turn on extra warnings with -W, there will be lots of false alarms,
> that's why this ifeq())
>
> ifeq (, $(findstring -W,$(EXTRA_CFLAGS)))
> subdir-ccflags-y += -Werror
> endif
This is exactly why it's recommended not to use -Werror on releases.
It's ok when developers use it, but for end users -Werror should not be
enabled by default.
--
Kalle Valo
next prev parent reply other threads:[~2013-07-21 16:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 2:46 [PATCH] ath: wil6210: Fix build error Larry Finger
2013-07-21 7:06 ` Vladimir Kondratiev
2013-07-21 15:14 ` Larry Finger
2013-07-21 15:35 ` Thomas Fjellstrom
2013-07-21 15:52 ` Vladimir Kondratiev
2013-07-21 16:55 ` Kalle Valo [this message]
2013-07-22 1:45 ` Ben Hutchings
2013-07-22 9:56 ` Vladimir Kondratiev
2013-07-22 16:17 ` Luis R. Rodriguez
2013-07-23 7:06 ` Vladimir Kondratiev
2013-07-23 7:13 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo5vyhrt.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=qca_vkondrat@qca.qualcomm.com \
--cc=thomas@fjellstrom.ca \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).