From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Johannes Berg <johannes@sipsolutions.net>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>,
Wireless <linux-wireless@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the wireless-next tree
Date: Thu, 16 Jan 2025 21:30:45 +0200 [thread overview]
Message-ID: <87cygmmu8q.fsf@kernel.org> (raw)
In-Reply-To: <e19a87ad9cd54bfa9907f3a043b25d30@realtek.com> (Ping-Ke Shih's message of "Thu, 16 Jan 2025 05:49:28 +0000")
Ping-Ke Shih <pkshih@realtek.com> writes:
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
>> Hi all,
>>
>> After merging the wireless-next tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/net/wireless/realtek/rtw88/led.c:19:6: error: redefinition of 'rtw_led_init'
>> 19 | void rtw_led_init(struct rtw_dev *rtwdev)
>> | ^~~~~~~~~~~~
>> In file included from drivers/net/wireless/realtek/rtw88/led.c:7:
>> drivers/net/wireless/realtek/rtw88/led.h:15:20: note: previous definition of 'rtw_led_init' with type
>> 'void(struct rtw_dev *)'
>> 15 | static inline void rtw_led_init(struct rtw_dev *rtwdev)
>> | ^~~~~~~~~~~~
>> drivers/net/wireless/realtek/rtw88/led.c:64:6: error: redefinition of 'rtw_led_deinit'
>> 64 | void rtw_led_deinit(struct rtw_dev *rtwdev)
>> | ^~~~~~~~~~~~~~
>> drivers/net/wireless/realtek/rtw88/led.h:19:20: note: previous definition of 'rtw_led_deinit' with type
>> 'void(struct rtw_dev *)'
>> 19 | static inline void rtw_led_deinit(struct rtw_dev *rtwdev)
>> | ^~~~~~~~~~~~~~
>>
>> Caused by commit
>>
>> 4b6652bc6d8d ("wifi: rtw88: Add support for LED blinking")
>>
>> I have used the wireless-next tree from next-20250115 for today.
>
> I reproduced this issue, and fixed it by a patch [1].
>
> [1] https://lore.kernel.org/linux-wireless/20250116054337.35723-1-pkshih@realtek.com/T/#u
The v2 of that patch is now applied:
https://git.kernel.org/wireless/wireless-next/c/b4bfbc50b1b9
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2025-01-16 19:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 2:08 linux-next: build failure after merge of the wireless-next tree Stephen Rothwell
2025-01-16 5:49 ` Ping-Ke Shih
2025-01-16 19:30 ` Kalle Valo [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-09 1:04 Stephen Rothwell
2024-10-09 7:04 ` Johannes Berg
[not found] <20111220131802.e3782dfbf8172281a7df5a5c@canb.auug.org.au>
[not found] ` <CAB=NE6V12m2_u6YGxhmqjNGs9OjdOKFpCAYu5cs_Hezwwk9LLA@mail.gmail.com>
[not found] ` <20111220135704.8c87c166d9ac18d4ea308107@canb.auug.org.au>
2011-12-20 3:24 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cygmmu8q.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).