From: Kalle Valo <kvalo@kernel.org>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>
Cc: David Mosberger-Tang <davidm@egauge.net>,
linux-wireless@vger.kernel.org, Ajay.Kathat@microchip.com
Subject: Re: [PATCH] [v4] wifi: wilc1000: validate chip id during bus probe
Date: Thu, 01 Feb 2024 12:08:06 +0200 [thread overview]
Message-ID: <87cytgv6nt.fsf@kernel.org> (raw)
In-Reply-To: <415a0e6e-5824-44a2-af2a-a75115d5a62e@bootlin.com> ("Alexis Lothoré"'s message of "Tue, 30 Jan 2024 10:06:44 +0100")
Alexis Lothoré <alexis.lothore@bootlin.com> writes:
> On 1/27/24 01:43, David Mosberger-Tang wrote:
>> Previously, the driver created a net device (typically wlan0) as soon
>> as the module was loaded. This commit changes the driver to follow
>> normal Linux convention of creating the net device only when bus
>> probing detects a supported chip.
>
> As already mentioned multiple times, I am skeptical about the validity of
> keeping netdev registration before chip presence check, but I am not the
> maintainer, so I let Ajay and Kalle decide for this.
I haven't checked the code but as a general comment I agree with Alexis,
registering netdev before the hardware is ready sounds odd to me.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-02-01 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 0:43 [PATCH] [v4] wifi: wilc1000: validate chip id during bus probe David Mosberger-Tang
2024-01-30 9:06 ` Alexis Lothoré
2024-02-01 2:55 ` Ajay.Kathat
2024-02-07 4:53 ` David Mosberger-Tang
2024-02-01 10:08 ` Kalle Valo [this message]
2024-02-07 4:59 ` David Mosberger-Tang
2024-02-07 4:52 ` David Mosberger-Tang
2024-02-07 11:41 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cytgv6nt.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Ajay.Kathat@microchip.com \
--cc=alexis.lothore@bootlin.com \
--cc=davidm@egauge.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).