From: Kalle Valo <kvalo@kernel.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: "Jérôme Pouiller" <jerome.pouiller@silabs.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: wfx: fix possible NULL pointer dereference in wfx_set_mfp_ap()
Date: Mon, 04 Dec 2023 18:10:40 +0200 [thread overview]
Message-ID: <87cyvmq77j.fsf@kernel.org> (raw)
In-Reply-To: <20231204155558.133839-1-dmantipov@yandex.ru> (Dmitry Antipov's message of "Mon, 4 Dec 2023 18:55:37 +0300")
Dmitry Antipov <dmantipov@yandex.ru> writes:
> Since 'ieee80211_beacon_get()' can return NULL, 'wfx_set_mfp_ap()'
> should check the return value before examining skb data. So convert
> the latter to return an appropriate error code and propagate it to
> return from 'wfx_start_ap()' as well. Compile tested only.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Patches like this should be tested on a real device.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-12-04 16:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 15:55 [PATCH] wifi: wfx: fix possible NULL pointer dereference in wfx_set_mfp_ap() Dmitry Antipov
2023-12-04 16:10 ` Kalle Valo [this message]
2023-12-04 16:50 ` Jérôme Pouiller
2023-12-04 17:11 ` [PATCH] [v2] " Dmitry Antipov
2023-12-11 10:01 ` Jérôme Pouiller
2023-12-12 15:33 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyvmq77j.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=jerome.pouiller@silabs.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).