From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <Ajay.Kathat@microchip.com>, <linux-wireless@vger.kernel.org>,
<Claudiu.Beznea@microchip.com>, <Sripad.Balwadgi@microchip.com>
Subject: Re: [PATCH] wifi: wilc1000: change firmware path from 'atmel' to 'microchip/wilc'
Date: Wed, 19 Jul 2023 13:37:39 +0300 [thread overview]
Message-ID: <87cz0o2nm4.fsf@kernel.org> (raw)
In-Reply-To: <20230705172754.61ca21ae@kernel.org> (Jakub Kicinski's message of "Wed, 5 Jul 2023 17:27:54 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
>> In order to address scenario#1, a fallback method that loads the FW from
>> the older path(/atmel) can be added in the driver. I think that change
>> will make it compatible for scenario#1.
>> Please suggest, if there is a generic/recommended approach to handle
>> backward compatibility for FW path change.
>
> I'm afraid you need to request from both new and old patch for some
> time. Push the change to linux-firmware, but make driver be compatible
> with both for maybe three full releases? Then the risk of someone still
> having stale linux-firmware goes down quite a bit.
I would say at least minimum of two years, preferably more to make it
possible to upgrade kernel on LTS distro releases.
> TBH renaming FW paths, much like renaming drivers is usually more risk
> than reward.
I agree, it's just extra work without no actually benefit. Maybe an
exception here is iwlwifi, that should be fixed as that clutters the top
level firmware directory with dozens of files:
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-07-19 10:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 1:22 [PATCH] wifi: wilc1000: change firmware path from 'atmel' to 'microchip/wilc' Ajay.Kathat
2023-07-05 21:03 ` Jakub Kicinski
2023-07-05 21:04 ` Jakub Kicinski
2023-07-06 0:12 ` Ajay.Kathat
2023-07-06 0:27 ` Jakub Kicinski
2023-07-19 10:37 ` Kalle Valo [this message]
2023-07-19 16:20 ` Ajay.Kathat
2023-07-20 14:50 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz0o2nm4.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Ajay.Kathat@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Sripad.Balwadgi@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).