From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DE1EC433F5 for ; Wed, 13 Oct 2021 09:06:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AD5D60E05 for ; Wed, 13 Oct 2021 09:06:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238640AbhJMJIW (ORCPT ); Wed, 13 Oct 2021 05:08:22 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:61895 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229987AbhJMJIT (ORCPT ); Wed, 13 Oct 2021 05:08:19 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1634115976; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=1qHkShs3XALDPvHG18LqNTL7RYD4za3niK7KNl48j6E=; b=xNVObdoXJsSle5g+vqHop+TNiJZOEKgwjFhjJYjfrBlAlGMMBY+iE600bu8Jw51ZEyoF7Gkx I85xlQLyvPopnoIcqwbfFaJ7YnwxKLevVCPig65zFojD2V4+AquH0xmwcLOEX+2ZYHdKQ1xX eMuhGunCBvYBtkczalFm0db8PpY= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 6166a1880605239689dbd2f2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 13 Oct 2021 09:06:16 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D07B1C43460; Wed, 13 Oct 2021 09:06:15 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 687F5C4338F; Wed, 13 Oct 2021 09:06:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 687F5C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Pkshih Cc: "linux-wireless\@vger.kernel.org" Subject: Re: [PATCH v7 00/24] rtw89: add Realtek 802.11ax driver References: <20211008035627.19463-1-pkshih@realtek.com> <87lf32622d.fsf@codeaurora.org> <878ryz4vfw.fsf@codeaurora.org> <72f1067becb44a7a962c5d43cefe189e@realtek.com> <87h7dlwj58.fsf@codeaurora.org> Date: Wed, 13 Oct 2021 12:06:12 +0300 In-Reply-To: (Pkshih's message of "Wed, 13 Oct 2021 08:55:29 +0000") Message-ID: <87czo9wayj.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Pkshih writes: >> -----Original Message----- >> From: kvalo=codeaurora.org@mg.codeaurora.org >> On >> Behalf Of Kalle Valo >> Sent: Wednesday, October 13, 2021 2:09 PM >> To: Pkshih >> Cc: linux-wireless@vger.kernel.org >> Subject: Re: [PATCH v7 00/24] rtw89: add Realtek 802.11ax driver >> >> Pkshih writes: >> >> >> -----Original Message----- >> >> From: kvalo=codeaurora.org@mg.codeaurora.org >> >> On >> >> Behalf Of Kalle Valo >> >> Sent: Monday, October 11, 2021 8:07 PM >> >> To: Pkshih >> >> Cc: linux-wireless@vger.kernel.org >> >> Subject: Re: [PATCH v7 00/24] rtw89: add Realtek 802.11ax driver >> >> >> >> Kalle Valo writes: >> >> >> >> > Ping-Ke Shih writes: >> >> > >> >> >> This driver named rtw89, which is the next generation of rtw88, supports >> >> >> Realtek 8852AE 802.11ax 2x2 chip whose new features are OFDMA, DBCC, >> >> >> Spatial reuse, TWT and BSS coloring; now some of them aren't implemented >> >> >> though. >> >> >> >> >> >> The chip architecture is entirely different from the chips supported by >> >> >> rtw88 like RTL8822CE 802.11ac chip. First of all, register address ranges >> >> >> are totally redefined, so it's impossible to reuse register definition. To >> >> >> communicate with firmware, new H2C/C2H format is proposed. In order to have >> >> >> better utilization, TX DMA flow is changed to two stages DMA. To provide >> >> >> rich RX status information, additional RX PPDU packets are added. >> >> >> >> >> >> Since there are so many differences mentioned above, we decide to propose >> >> >> a new driver. It has many authors, they are listed in alphabetic order: >> >> >> >> >> >> Chin-Yen Lee >> >> >> Ping-Ke Shih >> >> >> Po Hao Huang >> >> >> Tzu-En Huang >> >> >> Vincent Fann >> >> >> Yan-Hsuan Chuang >> >> >> Zong-Zhe Yang >> >> >> >> >> >> Tested-by: Brian Norris >> >> >> Signed-off-by: Ping-Ke Shih >> >> >> >> >> >> v7: >> >> >> - use consistent license of Kconfig >> >> >> - remove #ifdef and dummy functions from coex.c >> >> >> - C2H handler of coex uses meaningful naming insetad, and use le32_to_cpu() >> >> >> to convert the value. >> >> >> - add icmp packet notify to coex >> >> >> - use function call instead of a work to notify coex about traffic changed >> >> >> - fix dereference security CAM NULL pointer while disconnecting occasionally >> >> >> - fill tx descriptor once a 32 bits word (Suggested by Arnd. Thanks!) >> >> >> - use static pci PS, so remove pci link_ps >> >> >> - make many mac tables constant >> >> >> - add early_h2c debugfs entry to notify firmware early >> >> >> - support new RA report format >> >> >> - configure retry_lowest_rate by band >> >> >> - avoid to use of whil(1) to parse power sequence >> >> >> - notify rfk before/after scanning to reset status >> >> >> - firmware: rtw89: 8852a: update fw to v0.13.30.0 >> >> >> https://github.com/pkshih/linux-firmware.git >> >> >> pick the commit 6595133a7cde82be932067afde834dcd036167f8 >> >> > >> >> > I have not reviewed this version yet, but I pushed it to the pending >> >> > branch for build testing: >> >> > >> >> > >> >> >> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?h= >> >> pending&id=c321740f93af1a31d9e149ce5077e28bd4e859f7 >> >> > >> >> > For the final commit my plan is to squash all patches into one big >> >> > patch. I will do that after reviewing v7, if everything is ok of course. >> >> > >> >> > Are there more Tested-by or Reviewed-by tags? >> > >> > Sorry for the late reply. Because our National Day is Oct. 10th, and >> > additional holiday on Oct. 11th. >> > >> > Aaron have tested v5 and a tag is given [1]. >> > >> > Tested-by: Aaron Ma >> >> I added Aaron to the commit log and pushed the driver to the master >> branch: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id >> =e3ec7017f6a20d12ddd9fe23d345ebb7b8c104dd >> >> So the driver is now officially accepted, a big thank you to everyone >> who participated with the review and testing! Now let's see what kind of >> reports we get from linux-next. >> > > Thank you! > > Should I add myself to the file MAINTAINERS? Heh, of course I forgot something. Good that you reminded about this :) Yes, please send a separate patch doing that. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches