From: Kalle Valo <kvalo@codeaurora.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: tehuang@realtek.com, yhchuang@realtek.com,
linux-wireless@vger.kernel.org,
clang-built-linux@googlegroups.com, arnd@arndb.de
Subject: Re: [PATCH 3/5] rtw88: add dump firmware fifo support
Date: Fri, 02 Oct 2020 11:14:29 +0300 [thread overview]
Message-ID: <87d021cae2.fsf@codeaurora.org> (raw)
In-Reply-To: <20201001190641.GA3723966@ubuntu-m3-large-x86> (Nathan Chancellor's message of "Thu, 1 Oct 2020 12:06:41 -0700")
+ arnd
Nathan Chancellor <natechancellor@gmail.com> writes:
>> +int rtw_fw_dump_fifo(struct rtw_dev *rtwdev, u8 fifo_sel, u32 addr, u32 size,
>> + u32 *buffer)
>> +{
>> + if (!rtwdev->chip->fw_fifo_addr) {
>
> This causes a clang warning, which points out it is probably not doing
> what you think it is:
>
> drivers/net/wireless/realtek/rtw88/fw.c:1485:21: warning: address of
> array 'rtwdev->chip->fw_fifo_addr' will always evaluate to 'true'
> [-Wpointer-bool-conversion]
> if (!rtwdev->chip->fw_fifo_addr) {
> ~~~~~~~~~~~~~~~^~~~~~~~~~~~
> 1 warning generated.
>
> Was fw_fifo_addr[0] intended or should the check just be deleted?
BTW what is the easiest way to install clang for build testing the
kernel? For GCC I use crosstool[1] which is awesome as it makes the
installation so simple, do we have something similar for clang?
Just supporting x86 would be fine, as my use case would be just to
reproduce build warnings.
[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-10-02 8:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 6:12 [PATCH 0/5] rtw88: add firmware crash recovery and some fixes tehuang
2020-09-25 6:12 ` [PATCH 1/5] rtw88: increse the size of rx buffer size tehuang
2020-09-29 8:23 ` Kalle Valo
2020-09-25 6:12 ` [PATCH 2/5] rtw88: handle and recover when firmware crash tehuang
2020-09-29 8:20 ` Kalle Valo
2020-09-25 6:12 ` [PATCH 3/5] rtw88: add dump firmware fifo support tehuang
2020-10-01 19:06 ` Nathan Chancellor
2020-10-02 8:14 ` Kalle Valo [this message]
2020-10-02 8:43 ` Nathan Chancellor
2020-10-06 5:53 ` Kalle Valo
2020-09-25 6:12 ` [PATCH 4/5] rtw88: add dump fw crash log tehuang
2020-09-25 6:12 ` [PATCH 5/5] rtw88: show current regulatory in tx power table tehuang
2020-09-25 16:29 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d021cae2.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-wireless@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).