From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC0B1C54FD0 for ; Thu, 23 Apr 2020 07:01:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7A8821569 for ; Thu, 23 Apr 2020 07:01:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="OAzIGJKg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726748AbgDWHB1 (ORCPT ); Thu, 23 Apr 2020 03:01:27 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:40180 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbgDWHB0 (ORCPT ); Thu, 23 Apr 2020 03:01:26 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587625285; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=jnGBvqgD2+rCZ5dqwcs/N0/DjWzyVn5656ZJjEr5E6M=; b=OAzIGJKgfr85qP3QxlRii25LA6STpSJc6aC+5Xf4J6IcwF359FXzoVjDlcTLcHoY57CbkuM6 0+UDTVrTQsBG/g+0dY+vK9NRvjmtRO+KCFhtkjisxJ3qPaRT6d5FizasnmJvMQYoF95SgmWi hT5IuJ/x1eJeAztbPJbzw0ceVuI= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ea13d35.7f87b6312490-smtp-out-n02; Thu, 23 Apr 2020 07:01:09 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C0E57C433F2; Thu, 23 Apr 2020 07:01:07 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 917ACC433D2; Thu, 23 Apr 2020 07:01:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 917ACC433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Kai-Heng Feng Cc: Tony Chuang , "David S. Miller" , "open list\:REALTEK WIRELESS DRIVER \(rtw88\)" , "open list\:NETWORKING DRIVERS" , open list Subject: Re: [PATCH 2/2] rtw88: Use udelay instead of usleep in atomic context References: <20200423063811.2636-1-kai.heng.feng@canonical.com> <20200423063811.2636-2-kai.heng.feng@canonical.com> <87h7xan1cy.fsf@kamboji.qca.qualcomm.com> Date: Thu, 23 Apr 2020 10:01:03 +0300 In-Reply-To: (Kai-Heng Feng's message of "Thu, 23 Apr 2020 14:53:18 +0800") Message-ID: <87d07yn0sw.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kai-Heng Feng writes: >> On Apr 23, 2020, at 14:49, Kalle Valo wrote: >> >> Kai-Heng Feng writes: >> >>> It's incorrect to use usleep in atomic context. >>> >>> Switch to a macro which uses udelay instead of usleep to prevent the issue. >>> >>> Signed-off-by: Kai-Heng Feng >> >> This fixes a regression, right? So there should be a Fixes line. > > Yes, but the regression commit isn't in Linus' tree, so the sha1 may change. No, the commit id won't change after I have commited the patch. I don't rebase my trees. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches