From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: davem@davemloft.net, linux-wireless@vger.kernel.org,
emmanuel.grumbach@intel.com, johannes.hirte@datenkhaos.de,
steven@uplinklabs.net, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH for v5.2] iwlwifi: mvm: disable TX-AMSDU on older NICs
Date: Wed, 03 Jul 2019 14:45:54 +0300 [thread overview]
Message-ID: <87d0irqr2l.fsf@codeaurora.org> (raw)
In-Reply-To: <1d7609a45e38725d57c2f78b5e437b83b7e49197.camel@coelho.fi> (Luca Coelho's message of "Wed, 03 Jul 2019 11:14:52 +0300")
Luca Coelho <luca@coelho.fi> writes:
> On Wed, 2019-07-03 at 11:10 +0300, Luca Coelho wrote:
>> From: Johannes Berg <johannes.berg@intel.com>
>>
>> On older NICs, we occasionally see issues with A-MSDU support,
>> where the commands in the FIFO get confused and then we see an
>> assert EDC because the next command in the FIFO isn't TX.
>>
>> We've tried to isolate this issue and understand where it comes
>> from, but haven't found any errors in building the A-MSDU in
>> software.
>>
>> At least for now, disable A-MSDU support on older hardware so
>> that users can use it again without fearing the assert.
>>
>> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=203315.
>>
>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>> ---
>
> Hi Dave,
>
> This is an important fix for a bug that has been reported by several
> users in bugzilla (and elsewhere). It fixes FW crashes that disrupt
> throughput and connectivity in general in very popular devices (Intel's
> WiFi 7000 and 8000 series).
>
> I know it's a bit late for v5.2, but if possible, it would be great to
> take this. Kalle is on vacation, so we agreed that I would send it
> directly to you.
Acked-by: Kalle Valo <kvalo@codeaurora.org>
--
Kalle Valo
next prev parent reply other threads:[~2019-07-03 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 8:10 [PATCH for v5.2] iwlwifi: mvm: disable TX-AMSDU on older NICs Luca Coelho
2019-07-03 8:14 ` Luca Coelho
2019-07-03 11:45 ` Kalle Valo [this message]
2019-07-24 23:55 ` Brian Norris
2019-07-25 5:55 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0irqr2l.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=johannes.hirte@datenkhaos.de \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=steven@uplinklabs.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).