From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Chuang <yhchuang@realtek.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
"Larry.Finger\@lwfinger.net" <Larry.Finger@lwfinger.net>,
Pkshih <pkshih@realtek.com>, Andy Huang <tehuang@realtek.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [RFC v2 03/12] rtw88: hci files
Date: Sat, 06 Oct 2018 15:29:08 +0300 [thread overview]
Message-ID: <87d0snfecr.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D172A54A@RTITMBSVM01.realtek.com.tw> (Tony Chuang's message of "Fri, 5 Oct 2018 12:07:06 +0000")
Tony Chuang <yhchuang@realtek.com> writes:
>> > + }
>> > +
>> > + info = IEEE80211_SKB_CB(skb);
>> > + ieee80211_tx_info_clear_status(info);
>> > + info->flags |= IEEE80211_TX_STAT_ACK;
>> > + ieee80211_tx_status_irqsafe(hw, skb);
>>
>> Always report ACK ?
>
> The ACK report is for mac80211 stack, it looks abnormal at the first glance.
> But we can only do this for every data frame because there is no ack report
> unless the driver ask the firmware to give one.
> Ask for every data frame is resource consuming.
I don't remember how mac80211 wants to handle the cases when the
hardware doesn't provide ack status, but lying that to mac80211 sounds
like a bad idea to me. Anyone have any suggestions how this should be
handled?
At the minimum add a proper comment explaining why you are lying to
mac80211.
--
Kalle Valo
next prev parent reply other threads:[~2018-10-06 12:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 8:02 [RFC v2 00/12] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips yhchuang
2018-10-03 8:02 ` [RFC v2 01/12] rtw88: main files yhchuang
2018-10-03 8:02 ` [RFC v2 02/12] rtw88: core files yhchuang
2018-10-04 11:42 ` Stanislaw Gruszka
2018-10-04 13:52 ` Stanislaw Gruszka
2018-10-08 8:22 ` Tony Chuang
2018-10-03 8:02 ` [RFC v2 03/12] rtw88: hci files yhchuang
2018-10-04 13:02 ` Stanislaw Gruszka
2018-10-04 13:25 ` Stanislaw Gruszka
2018-10-05 12:07 ` Tony Chuang
2018-10-06 12:29 ` Kalle Valo [this message]
2018-10-08 9:03 ` Tony Chuang
2018-10-08 9:34 ` Stanislaw Gruszka
2019-03-25 14:33 ` Brian Norris
2018-10-03 8:02 ` [RFC v2 04/12] rtw88: trx files yhchuang
2018-10-04 13:19 ` Stanislaw Gruszka
2018-10-05 9:20 ` Tony Chuang
2018-10-06 12:32 ` Kalle Valo
2018-10-08 9:19 ` Stanislaw Gruszka
2018-10-08 9:35 ` Tony Chuang
2018-10-08 9:25 ` Stanislaw Gruszka
2018-10-03 8:02 ` [RFC v2 05/12] rtw88: mac files yhchuang
2018-10-03 8:02 ` [RFC v2 06/12] rtw88: fw and efuse files yhchuang
2018-10-04 10:49 ` Stanislaw Gruszka
2018-10-05 9:19 ` Tony Chuang
2018-10-08 9:15 ` Stanislaw Gruszka
2018-10-06 12:34 ` Kalle Valo
2018-10-03 8:02 ` [RFC v2 07/12] rtw88: phy files yhchuang
2018-10-03 8:02 ` [RFC v2 08/12] rtw88: debug files yhchuang
2018-10-03 8:02 ` [RFC v2 09/12] rtw88: chip files yhchuang
2018-10-03 8:02 ` [RFC v2 10/12] rtw88: 8822B init table yhchuang
2018-10-03 8:02 ` [RFC v2 11/12] rtw88: 8822C " yhchuang
2018-10-03 8:02 ` [RFC v2 12/12] rtw88: Kconfig & Makefile yhchuang
2018-10-03 16:15 ` [RFC v2 00/12] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips Sid Hayn
2018-10-03 16:52 ` Larry Finger
2018-10-03 16:57 ` Sid Hayn
2018-10-03 17:38 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0snfecr.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=sgruszka@redhat.com \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).