From: Kalle Valo <kvalo@codeaurora.org>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Felix Fietkau <nbd@nbd.name>,
arnd@arndb.de
Subject: Re: [PATCH] net: wireless: mediatek: fix mt76 LEDS build error
Date: Fri, 07 Sep 2018 12:05:13 +0300 [thread overview]
Message-ID: <87d0tp65km.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180907075612.GB2725@localhost.localdomain> (Lorenzo Bianconi's message of "Fri, 7 Sep 2018 09:56:12 +0200")
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> All of the mt76 driver options use its mac80211.o component,
>> which uses led interfaces, so each of them should depend on
>> LEDS_CLASS.
>>
>> Fixes this build error:
>>
>> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_led_init':
>> drivers/net/wireless/mediatek/mt76/mac80211.c:119: undefined
>> reference to `devm_of_led_classdev_register'
>>
>> Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets")
>>
>
> Hi Randy,
>
> a fix for it has been already proposed by Arnd here:
> https://marc.info/?l=linux-wireless&m=151628136830540&w=2
> but it has not been applied yet
Yet? Arnd's patch is not on my queue as it's from last January and Felix
had a comment for it:
https://patchwork.kernel.org/patch/10173197/
--
Kalle Valo
next prev parent reply other threads:[~2018-09-07 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 22:28 [PATCH] net: wireless: mediatek: fix mt76 LEDS build error Randy Dunlap
2018-09-07 7:56 ` Lorenzo Bianconi
2018-09-07 9:05 ` Kalle Valo [this message]
2018-09-19 16:07 ` Kalle Valo
2018-09-19 16:12 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0tp65km.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox