From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Eric Bentley <eric.bentley@lairdtech.com>
Cc: "ath6kl@lists.infradead.org" <ath6kl@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] Allow the radio to report 0 dbm txpower without timing out
Date: Tue, 30 Aug 2016 04:42:26 +0000 [thread overview]
Message-ID: <87d1kqj2a6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1472531450-19115-1-git-send-email-eric.bentley@lairdtech.com> (Eric Bentley's message of "Tue, 30 Aug 2016 00:30:50 -0400")
Eric Bentley <eric.bentley@lairdtech.com> writes:
> The ath6kl driver attempts to get the txpower from the radio by first
> clearing the existing stored value and then watching the value to become
> non-zero. However, this value is in dbm and 0 is a valid value.
>
> APs allow setting client power to values from -127..127. However, The rad=
io
> is not capable of setting values less then 0 and so will report txpower
> as 0 for both negative and 0 client power.
>
> The 6004 defaults to 63dbm which is then limited by regulatory and
> hardware limits with max of 18dbm (6003 max is 16dbm), therefore we can
> use values larger then this to be able to determine when the value has
> been updated.
>
> Set the value to a nonsensical value (255) and wait for it to change.
Please prefix the title with "ath6kl: ". Also Signed-off-by is missing.
In the title you mention a bit about the bug you are fixing, but it
would be useful to describe more about it in the commit log. From user's
point of view, how did ath6kl behave before your patch and how will it
change after your patch?
--=20
Kalle Valo=
prev parent reply other threads:[~2016-08-30 4:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 4:30 [PATCH] Allow the radio to report 0 dbm txpower without timing out Eric Bentley
2016-08-30 4:42 ` Valo, Kalle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1kqj2a6.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl@lists.infradead.org \
--cc=eric.bentley@lairdtech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox