From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH V2 0/3] Fix few WMI/HTT interfaces
Date: Thu, 5 Nov 2015 13:03:15 +0200 [thread overview]
Message-ID: <87d1vobte4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20151105045754.GA12919@qca.qualcomm.com> (Vasanthakumar Thiagarajan's message of "Thu, 5 Nov 2015 10:28:00 +0530")
Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> writes:
> On Wed, Nov 04, 2015 at 07:59:39PM +0200, Kalle Valo wrote:
>> Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> writes:
>>
>> > This patch set fixes mismatch in peer_assoc complete wmi command for
>> > version 10.4 and peer_id configuration for HTT version < 3.4.
>> >
>> > V2:
>> > - Add cover letter
>> > - Rename ath10k_mac_need_offchan_tx_work() to
>> > ath10k_mac_tx_frm_has_freq(). Add htt-op-version check
>> > to the helper and use it in ath10k_htt_tx() while configuring
>> > peerid.
>> >
>> > Vasanthakumar Thiagarajan (3):
>> > ath10k: Fix peer assoc complete WMI command for 10.4
>> > ath10k: Rename the helper which is used for off-channel tx
>> > ath10k: Fix peerid configuration in htt tx desc for htt version < 3.4
>>
>> These had a conflict but you didn't use ath.git as the baseline so I
>> can't easily fix them. Please try always to use clean ath.git master
>> branch as the baseline for your patches.
>>
>> Applying: ath10k: Fix peer assoc complete WMI command for 10.4
>> fatal: sha1 information is lacking or useless (drivers/net/wireless/ath/ath10k/wmi.h).
>> Repository lacks necessary blobs to fall back on 3-way merge.
>> Cannot fall back to three-way merge.
>> Patch failed at 0001 ath10k: Fix peer assoc complete WMI command for 10.4
>
> Sorry for this. I prepared these patches on ath:master on top of my other pending
> patch set. Not sure what went wrong.
If you have two patchsets you shouldn't have them on the same branch,
unless they have a strict dependency with each other of course. I prefer
that you have two separate topic branches which both use the master
branch as the baseline as then it's easiest for me to handle conflicts
etc.
--
Kalle Valo
next prev parent reply other threads:[~2015-11-05 11:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 12:05 [PATCH V2 0/3] Fix few WMI/HTT interfaces Vasanthakumar Thiagarajan
2015-11-04 12:05 ` [PATCH V2 1/3] ath10k: Fix peer assoc complete WMI command for 10.4 Vasanthakumar Thiagarajan
2015-11-04 12:05 ` [PATCH V2 2/3] ath10k: Rename the helper which is used for off-channel tx Vasanthakumar Thiagarajan
2015-11-04 12:05 ` [PATCH V2 3/3] ath10k: Fix peerid configuration in htt tx desc for htt version < 3.4 Vasanthakumar Thiagarajan
2015-11-04 17:59 ` [PATCH V2 0/3] Fix few WMI/HTT interfaces Kalle Valo
2015-11-05 4:58 ` Vasanthakumar Thiagarajan
2015-11-05 11:03 ` Kalle Valo [this message]
2015-11-06 5:45 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1vobte4.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).