From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <greearb@candelatech.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/8] ath10k: fix spelling mistakes and add details to mac logging.
Date: Wed, 4 Feb 2015 10:33:37 +0200 [thread overview]
Message-ID: <87d25qulcu.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1421087564-10384-3-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Mon, 12 Jan 2015 10:32:39 -0800")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> A bit of general cleanup to make debug messages more useful.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
[...]
> - ath10k_warn(ar, "failed to synchronise monitor vdev %i: %d\n",
> + ath10k_warn(ar, "failed to synchronize monitor vdev %i: %d (stop)\n",
Hehe, spelling fixes? You know not everyone speak "American" ;)
Anyway, I changed the patch in pending branch to follow the style with
other similar warning messages:
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 40c666615993..f4ab3d0a5fa0 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -608,7 +608,7 @@ static int ath10k_monitor_vdev_start(struct ath10k *ar, int vdev_id)
ret = ath10k_vdev_setup_sync(ar);
if (ret) {
- ath10k_warn(ar, "failed to synchronize setup for monitor vdev %i: %d (start)\n",
+ ath10k_warn(ar, "failed to synchronize setup for monitor vdev %i start: %d\n",
vdev_id, ret);
return ret;
}
@@ -655,7 +655,7 @@ static int ath10k_monitor_vdev_stop(struct ath10k *ar)
ret = ath10k_vdev_setup_sync(ar);
if (ret)
- ath10k_warn(ar, "failed to synchronize monitor vdev %i: %d (stop)\n",
+ ath10k_warn(ar, "failed to synchronize monitor vdev %i stop: %d\n",
ar->monitor_vdev_id, ret);
ath10k_dbg(ar, ATH10K_DBG_MAC, "mac monitor vdev %i stopped\n",
@@ -924,8 +924,9 @@ static int ath10k_vdev_start_restart(struct ath10k_vif *arvif, bool restart)
ret = ath10k_vdev_setup_sync(ar);
if (ret) {
- ath10k_warn(ar, "failed to synchronize setup for vdev %i: %d (restart %d)\n",
- arg.vdev_id, ret, restart);
+ ath10k_warn(ar,
+ "failed to synchronize setup for vdev %i restart %d: %d\n",
+ arg.vdev_id, restart, ret);
return ret;
}
@@ -963,7 +964,7 @@ static int ath10k_vdev_stop(struct ath10k_vif *arvif)
ret = ath10k_vdev_setup_sync(ar);
if (ret) {
- ath10k_warn(ar, "failed to synchronize setup for vdev %i: %d (stop)\n",
+ ath10k_warn(ar, "failed to synchronize setup for vdev %i stop: %d\n",
arvif->vdev_id, ret);
return ret;
}
--
Kalle Valo
next prev parent reply other threads:[~2015-02-04 8:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 18:32 [PATCH 1/8] ath10k: scan should handle scan-start-failed event properly greearb
2015-01-12 18:32 ` [PATCH 2/8] ath10k: add wmi-id to htc credits debugging greearb
2015-01-12 18:32 ` [PATCH 3/8] ath10k: fix spelling mistakes and add details to mac logging greearb
2015-02-04 8:33 ` Kalle Valo [this message]
2015-01-12 18:32 ` [PATCH 4/8] ath10k: make dbglog debug messages be 'warn' level greearb
2015-02-04 7:44 ` Kalle Valo
2015-01-12 18:32 ` [RFC 5/8] ath10k: add firmware wmi keep-alive message greearb
2015-01-12 18:32 ` [PATCH 6/8] ath10k: fix spelling in htt code comment greearb
2015-01-12 18:32 ` [PATCH 7/8] ath10k: start using htt/pci/ce transfer_id properly greearb
2015-01-12 18:32 ` [PATCH 8/8] ath10k: fix CE_DESC_FLAGS_META_DATA_LSB definition greearb
2015-02-04 8:37 ` [PATCH 1/8] ath10k: scan should handle scan-start-failed event properly Kalle Valo
2015-02-04 15:31 ` Ben Greear
2015-02-15 15:03 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2015-01-12 19:41 greearb
2015-01-12 19:41 ` [PATCH 3/8] ath10k: fix spelling mistakes and add details to mac logging greearb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d25qulcu.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).