From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] ath10k: add tracing for frame transmission
Date: Tue, 7 Oct 2014 19:19:05 +0300 [thread overview]
Message-ID: <87d2a3j1ja.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1412615346-18010-1-git-send-email-rmanohar@qti.qualcomm.com> (Rajkumar Manoharan's message of "Mon, 6 Oct 2014 22:39:06 +0530")
Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> Add tracing support to forward management and data frames to
> user space for packet inspection.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
[...]
> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> @@ -291,6 +291,9 @@ static inline struct sk_buff *ath10k_htt_rx_netbuf_pop(struct ath10k_htt *htt)
> htt->rx_ring.sw_rd_idx.msdu_payld = idx;
> htt->rx_ring.fill_cnt--;
>
> + trace_ath10k_htt_rx_pop_msdu(ar, msdu->data, msdu->len +
> + skb_tailroom(msdu));
Why add skb_tailroom() to the length? I think that deserves a comment.
--
Kalle Valo
next prev parent reply other threads:[~2014-10-07 16:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 17:09 [PATCH v2] ath10k: add tracing for frame transmission Rajkumar Manoharan
2014-10-07 14:32 ` Kalle Valo
2014-10-08 2:59 ` Rajkumar Manoharan
2014-10-07 16:19 ` Kalle Valo [this message]
2014-10-08 3:13 ` Rajkumar Manoharan
2014-10-08 10:19 ` Kalle Valo
2014-10-08 10:27 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2a3j1ja.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).