From: Kalle Valo <kvalo@adurom.com>
To: David Gnedt <david.gnedt@davizone.at>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Grazvydas Ignotas <notasas@gmail.com>,
Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
Subject: Re: [PATCH 03/18] wl1251: fix scan behaviour while not associated
Date: Tue, 01 Feb 2011 23:24:15 +0200 [thread overview]
Message-ID: <87d3nbcutc.fsf@purkki.adurom.net> (raw)
In-Reply-To: <4D45B7BA.9080402@davizone.at> (David Gnedt's message of "Sun\, 30 Jan 2011 20\:10\:50 +0100")
David Gnedt <david.gnedt@davizone.at> writes:
> With a dissacociated card I often encoutered very long scan delays.
>
> My guess is that it has something to do with the cards DTIM handling and
> another firmware bug mentioned in the TI WLAN driver, which is described as
> the card may never end scanning if the channel is overloaded because it
> can't send probe requests. I think the firmware somehow also tries to
> receive DTIM messages when the BSSID is not set. Therefore most of the time
> it waits for DTIM messages and can't do scanning work.
>
> Anyway we can workaround this misbehaviour by setting the HIGH_PRIORITY
> bit for scans in disassociated state.
Now that's a weird problem. I wonder this wasn't reported with the
fremantle kernels. How often did you see the problem?
> --- a/drivers/net/wireless/wl1251/cmd.c
> +++ b/drivers/net/wireless/wl1251/cmd.c
> @@ -419,7 +419,10 @@ int wl1251_cmd_scan(struct wl1251 *wl, u8 *ssid, size_t ssid_len,
> struct wl1251_cmd_scan *cmd;
> int i, ret = 0;
>
> - wl1251_debug(DEBUG_CMD, "cmd scan");
> + wl1251_debug(DEBUG_CMD, "cmd scan channels %d ssid(%d) '%s'",
> + n_channels, ssid_len, ssid);
ssid is not a valid string and hence you cannot print it with %s.
> + /*
> + * Use high priority scan when not associated to prevent fw issue
> + * causing never-ending scans (sometimes 20+ minutes).
> + * Note: This bug may be caused by the fw's DTIM handling.
> + */
> + if (is_zero_ether_addr(wl->bssid))
> + cmd->params.scan_options |= WL1251_SCAN_OPT_PRIORITY_HIGH;
Can you resend the patch with just this part and the accompanying
defines, please? It's better to have debug messages improvements in a
separate patch.
--
Kalle Valo
next prev parent reply other threads:[~2011-02-01 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D45A598.20709@davizone.at>
2011-01-30 19:10 ` [PATCH 03/18] wl1251: fix scan behaviour while not associated David Gnedt
2011-02-01 21:24 ` Kalle Valo [this message]
2011-02-06 14:04 ` David Gnedt
2011-02-02 22:17 ` Grazvydas Ignotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3nbcutc.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=GNUtoo@no-log.org \
--cc=david.gnedt@davizone.at \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).