From: Kalle Valo <kalle.valo@iki.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Alina Friedrichsen <x-alina@gmx.net>,
linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] mac80211: Remove TSF atomic requirement from the documentation
Date: Sat, 07 Feb 2009 09:34:33 +0200 [thread overview]
Message-ID: <87d4duitti.fsf@litku.valot.fi> (raw)
In-Reply-To: <1233954680.4175.36.camel@johannes.local> (Johannes Berg's message of "Fri\, 06 Feb 2009 22\:11\:20 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Fri, 2009-02-06 at 23:08 +0200, Kalle Valo wrote:
>
>> Alina, it would be nice to explicitly mention that the function can
>> sleep. Otherwise driver authors need to guess if sleeping is allowed
>> or not.
>
> That's a larger project to actually annotate all of them either way ;)
Yes, but we can start with smaller pieces ;)
> I think we only mention atomicity requirements right now.
I found only one spot:
* @set_key: See the section "Hardware crypto acceleration"
* This callback can sleep, and is only called between add_interface
But, like you said, we can add these later.
--
Kalle Valo
prev parent reply other threads:[~2009-02-07 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 16:58 [PATCH] mac80211: Remove TSF atomic requirement from the documentation Alina Friedrichsen
2009-02-06 19:21 ` Kalle Valo
2009-02-06 20:44 ` Johannes Berg
2009-02-06 21:08 ` Kalle Valo
2009-02-06 21:11 ` Johannes Berg
2009-02-07 7:34 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d4duitti.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=x-alina@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).