linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@iki.fi>
To: Vivek Natarajan <Vivek.Natarajan@Atheros.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: multicast traffic and ath9k
Date: Fri, 09 Jan 2009 18:37:01 +0200	[thread overview]
Message-ID: <87d4ewtp02.fsf@litku.valot.fi> (raw)
In-Reply-To: <44EE5C37ADC36343B0625A05DD408C4845A77DAF08@CHEXMB-01.global.atheros.com> (Vivek Natarajan's message of "Fri\, 9 Jan 2009 19\:29\:25 +0530")

Vivek Natarajan <Vivek.Natarajan@Atheros.com> writes:

> Johannes Berg wrote:
>
>> > Is the mc bit checking done only on enabling power save? if set
>> > and mc packets are received, how does it automatically go back to
>> > sleep and wouldn't there be any conflict between mac80211 and the
>> > hw regarding power state since mac80211 is not aware of the mc
>> > bit induced state change?
>
>> I don't think there would be a conflict. mac80211's CONF_PS is always
>> only "go to sleep if you can", so receiving multicast traffic would
>> obviously imply not being able to go to sleep. 

Yes, there is no conflict. If stlc45xx firmware notices that multicast
tim bit is set, it will just stay awake long enough to receive all the
multicast frames, delivers them to the host and goes immediately back
to sleep.

>> When mac80211 then unsets the CONF_PS flag you'd just not go back
>> to sleep after being awake for MC traffic.
>
> How does the mac80211 know if the hw is receiving mc traffic or not and
> unset the CONF_PS flag accordingly? Am I missing something basic here?

Why would mac80211 need to unset CONF_PS? It can just receive the
multicast frames from the driver, it doesn't need to change the power
save state.

> Maybe p54 (stlc45xx) has the answer for how it goes back to sleep
> after mc traffic.

stlc45xx firmware handles multicast frames automatically.

-- 
Kalle Valo

      parent reply	other threads:[~2009-01-09 16:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07 16:36 multicast traffic and ath9k Johannes Berg
2009-01-09 11:50 ` Vivek Natarajan
2009-01-09 11:57   ` Johannes Berg
2009-01-09 12:56 ` Vivek Natarajan
2009-01-09 13:07   ` Johannes Berg
2009-01-09 13:59     ` Vivek Natarajan
2009-01-09 16:13       ` Christian Lamparter
2009-01-09 17:33         ` Kalle Valo
2009-01-09 16:37       ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d4ewtp02.fsf@litku.valot.fi \
    --to=kalle.valo@iki.fi \
    --cc=Vivek.Natarajan@Atheros.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).