From: Kalle Valo <Kalle.Valo@iki.fi>
To: Michael Buesch <mb@bu3sch.de>
Cc: bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] b43legacy: Change the hardware radio enable logic and cleanup code
Date: Sat, 22 Sep 2007 10:05:21 +0300 [thread overview]
Message-ID: <87d4wbnpse.fsf@litku.valot.fi> (raw)
In-Reply-To: <200709211522.01273.mb@bu3sch.de> (Michael Buesch's message of "Fri\, 21 Sep 2007 15\:22\:00 +0200")
Michael Buesch <mb@bu3sch.de> writes:
>> Index: wireless-dev/drivers/net/wireless/b43legacy/leds.c
>> ===================================================================
>> --- wireless-dev.orig/drivers/net/wireless/b43legacy/leds.c
>> +++ wireless-dev/drivers/net/wireless/b43legacy/leds.c
>> @@ -182,6 +182,7 @@ void b43legacy_leds_update(struct b43leg
>> unsigned long interval = 0;
>> u16 ledctl;
>> unsigned long flags;
>> + bool radio_enabled = (phy->radio_on && dev->radio_hw_enable);
>
> Just that you are aware of it:
> This is a racy access to the radio_hw_enable variable, as we don't take
> the mutex here (we can't and we don't want). But it's OK, since nobody
> cares if the LED is racing for a second and displays the wrong state
> for a second.
> Same goes for the phy->radio_on access.
As a side note, it would be nice to have this as a comment in the
code. Makes it easier for other people reading the code and wondering
if this a bug or not.
--
Kalle Valo
prev parent reply other threads:[~2007-09-22 7:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 1:10 [PATCH] b43legacy: Change the hardware radio enable logic and cleanup code Larry Finger
2007-09-21 13:22 ` Michael Buesch
2007-09-21 15:54 ` Larry Finger
2007-09-22 7:05 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d4wbnpse.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).