From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Masashi Honma <masashi.honma@gmail.com>, linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net
Subject: Re: [PATCH v7 1/6] wifi: mac80211: Use struct instead of macro for PREQ frame
Date: Thu, 21 May 2026 09:49:23 -0700 [thread overview]
Message-ID: <87dfbe33-7705-4ee7-bdde-565d2dfc8287@oss.qualcomm.com> (raw)
In-Reply-To: <20260521085647.394151-1-masashi.honma@gmail.com>
On 5/21/2026 1:56 AM, Masashi Honma wrote:
> In preparation for subsequent patches.
>
> Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
I'm surprised Johannes hasn't pushed back on your sparse commit text.
We have guidelines that you aren't following:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
Having commit text that fully describes what you are doing and why you are
doing it makes it much easier for folks to understand and review your patches.
/jeff
next prev parent reply other threads:[~2026-05-21 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 8:56 [PATCH v7 1/6] wifi: mac80211: Use struct instead of macro for PREQ frame Masashi Honma
2026-05-21 8:56 ` [PATCH v7 2/6] wifi: mac80211: Use struct instead of macro for PREP frame Masashi Honma
2026-05-21 8:56 ` [PATCH v7 3/6] wifi: mac80211: Use struct instead of macro for PERR frame Masashi Honma
2026-05-21 8:56 ` [PATCH v7 4/6] wifi: mac80211: Fix overread in PREQ frame processing Masashi Honma
2026-05-21 8:56 ` [PATCH v7 5/6] wifi: mac80211: Fix overread in PREP " Masashi Honma
2026-05-21 8:56 ` [PATCH v7 6/6] wifi: mac80211: Fix PERR " Masashi Honma
2026-05-21 16:49 ` Jeff Johnson [this message]
2026-05-21 22:58 ` [PATCH v7 1/6] wifi: mac80211: Use struct instead of macro for PREQ frame Masashi Honma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87dfbe33-7705-4ee7-bdde-565d2dfc8287@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=masashi.honma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox