[PATCH] wifi: ath10k: add channel 177 for 5 GHz band

[PATCH] wifi: ath10k: add channel 177 for 5 GHz band

[Paweł Owoc]

Add support for channel 177 (5885 MHz ) for the 5 GHz band.

Tested-on: qca988x hw2.0 firmware ver 10.2.4-1.0-00047

Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
---
 drivers/net/wireless/ath/ath10k/core.h | 4 ++--
 drivers/net/wireless/ath/ath10k/mac.c  | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index 446dca74f06a..3dff8c028526 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -39,8 +39,8 @@
 #define WMI_READY_TIMEOUT (5 * HZ)
 #define ATH10K_FLUSH_TIMEOUT_HZ (5 * HZ)
 #define ATH10K_CONNECTION_LOSS_HZ (3 * HZ)
-#define ATH10K_NUM_CHANS 41
-#define ATH10K_MAX_5G_CHAN 173
+#define ATH10K_NUM_CHANS 42
+#define ATH10K_MAX_5G_CHAN 177
 
 /* Antenna noise floor */
 #define ATH10K_DEFAULT_NOISE_FLOOR -95
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index a5da32e87106..aabe70fcd065 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -9543,6 +9543,7 @@ static const struct ieee80211_channel ath10k_5ghz_channels[] = {
 	CHAN5G(165, 5825, 0),
 	CHAN5G(169, 5845, 0),
 	CHAN5G(173, 5865, 0),
+	CHAN5G(177, 5885, 0),
 	/* If you add more, you may need to change ATH10K_MAX_5G_CHAN */
 	/* And you will definitely need to change ATH10K_NUM_CHANS in core.h */
 };
-- 
2.45.2

[PATCH v2] wifi: ath10k: add channel 177 for 5 GHz band

[Paweł Owoc]

Add support for channel 177 (5885 MHz ) for the 5 GHz band.

Tested-on: qca988x hw2.0 firmware ver 10.2.4-1.0-00047

Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
---
 drivers/net/wireless/ath/ath10k/core.h | 4 ++--
 drivers/net/wireless/ath/ath10k/mac.c  | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index 446dca74f06a..3dff8c028526 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -39,8 +39,8 @@
 #define WMI_READY_TIMEOUT (5 * HZ)
 #define ATH10K_FLUSH_TIMEOUT_HZ (5 * HZ)
 #define ATH10K_CONNECTION_LOSS_HZ (3 * HZ)
-#define ATH10K_NUM_CHANS 41
-#define ATH10K_MAX_5G_CHAN 173
+#define ATH10K_NUM_CHANS 42
+#define ATH10K_MAX_5G_CHAN 177
 
 /* Antenna noise floor */
 #define ATH10K_DEFAULT_NOISE_FLOOR -95
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 646e1737d4c4..cee6a4d287b5 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -9543,6 +9543,7 @@ static const struct ieee80211_channel ath10k_5ghz_channels[] = {
 	CHAN5G(165, 5825, 0),
 	CHAN5G(169, 5845, 0),
 	CHAN5G(173, 5865, 0),
+	CHAN5G(177, 5885, 0),
 	/* If you add more, you may need to change ATH10K_MAX_5G_CHAN */
 	/* And you will definitely need to change ATH10K_NUM_CHANS in core.h */
 };
-- 
2.46.0

Re: [PATCH v2] wifi: ath10k: add channel 177 for 5 GHz band

[Jeff Johnson]

On 10/8/2024 11:49 PM, Paweł Owoc wrote:> Add support for channel 177 (5885
MHz ) for the 5 GHz band.
> 
> Tested-on: qca988x hw2.0 firmware ver 10.2.4-1.0-00047

Can you elaborate on what was tested in your commit text? And more
importantly, what is the impact on existing devices, especially given that
existing devices would not have calibration data for this channel in the board
files? Does the QCA988x board file even have calibration data for this channel?

> 
> Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
> ---

what is the diff from v1?
for future reference when you submit a new version of a patch you should
include a patch changelog after the ---, see:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

>  drivers/net/wireless/ath/ath10k/core.h | 4 ++--
>  drivers/net/wireless/ath/ath10k/mac.c  | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
> index 446dca74f06a..3dff8c028526 100644
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -39,8 +39,8 @@
>  #define WMI_READY_TIMEOUT (5 * HZ)
>  #define ATH10K_FLUSH_TIMEOUT_HZ (5 * HZ)
>  #define ATH10K_CONNECTION_LOSS_HZ (3 * HZ)
> -#define ATH10K_NUM_CHANS 41
> -#define ATH10K_MAX_5G_CHAN 173
> +#define ATH10K_NUM_CHANS 42
> +#define ATH10K_MAX_5G_CHAN 177
>  
>  /* Antenna noise floor */
>  #define ATH10K_DEFAULT_NOISE_FLOOR -95
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 646e1737d4c4..cee6a4d287b5 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -9543,6 +9543,7 @@ static const struct ieee80211_channel ath10k_5ghz_channels[] = {
>  	CHAN5G(165, 5825, 0),
>  	CHAN5G(169, 5845, 0),
>  	CHAN5G(173, 5865, 0),
> +	CHAN5G(177, 5885, 0),
>  	/* If you add more, you may need to change ATH10K_MAX_5G_CHAN */
>  	/* And you will definitely need to change ATH10K_NUM_CHANS in core.h */
>  };

Re: [PATCH v2] wifi: ath10k: add channel 177 for 5 GHz band

[Paweł Owoc]

On Fri, Oct 11, 2024 at 6:51 PM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
>
> On 10/8/2024 11:49 PM, Paweł Owoc wrote:> Add support for channel 177 (5885
> MHz ) for the 5 GHz band.
> >
> > Tested-on: qca988x hw2.0 firmware ver 10.2.4-1.0-00047
>
> Can you elaborate on what was tested in your commit text? And more
> importantly, what is the impact on existing devices, especially given that
> existing devices would not have calibration data for this channel in the board
> files? Does the QCA988x board file even have calibration data for this channel?
>
In the case of ath10k we use an external regulatory database.
For the country "US" channels 169, 173 and 177 are marked as NO-IR and
we cannot run AP on them.
Even if channels are not disabled in the board files:
            * 5845.0 MHz [169] (27.0 dBm) (no IR)
            * 5865.0 MHz [173] (27.0 dBm) (no IR)
            * 5885.0 MHz [177] (27.0 dBm) (no IR)

I only tested the use as a client on channel 177:
root@OpenWrt:~# iwinfo phy1 scan
Cell 01 - Address: XX:XX:XX:XX:XX:XX
          ESSID: "ch177"
          Mode: Master  Frequency: 5.885 GHz  Band: 5 GHz  Channel: 177
          Signal: -43 dBm  Quality: 67/70
          Encryption: mixed WPA2/WPA3 PSK/SAE (CCMP)
          HT Operation:
                    Primary Channel: 177
                    Secondary Channel Offset: no secondary
                    Channel Width: 20 MHz
> >
> > Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
> > ---
>
> what is the diff from v1?
> for future reference when you submit a new version of a patch you should
> include a patch changelog after the ---, see:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
>
There are no differences. My previous patch was deferred. I don't know
exactly how to proceed in such a case.

> >  drivers/net/wireless/ath/ath10k/core.h | 4 ++--
> >  drivers/net/wireless/ath/ath10k/mac.c  | 1 +
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
> > index 446dca74f06a..3dff8c028526 100644
> > --- a/drivers/net/wireless/ath/ath10k/core.h
> > +++ b/drivers/net/wireless/ath/ath10k/core.h
> > @@ -39,8 +39,8 @@
> >  #define WMI_READY_TIMEOUT (5 * HZ)
> >  #define ATH10K_FLUSH_TIMEOUT_HZ (5 * HZ)
> >  #define ATH10K_CONNECTION_LOSS_HZ (3 * HZ)
> > -#define ATH10K_NUM_CHANS 41
> > -#define ATH10K_MAX_5G_CHAN 173
> > +#define ATH10K_NUM_CHANS 42
> > +#define ATH10K_MAX_5G_CHAN 177
> >
> >  /* Antenna noise floor */
> >  #define ATH10K_DEFAULT_NOISE_FLOOR -95
> > diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> > index 646e1737d4c4..cee6a4d287b5 100644
> > --- a/drivers/net/wireless/ath/ath10k/mac.c
> > +++ b/drivers/net/wireless/ath/ath10k/mac.c
> > @@ -9543,6 +9543,7 @@ static const struct ieee80211_channel ath10k_5ghz_channels[] = {
> >       CHAN5G(165, 5825, 0),
> >       CHAN5G(169, 5845, 0),
> >       CHAN5G(173, 5865, 0),
> > +     CHAN5G(177, 5885, 0),
> >       /* If you add more, you may need to change ATH10K_MAX_5G_CHAN */
> >       /* And you will definitely need to change ATH10K_NUM_CHANS in core.h */
> >  };
>

Re: [PATCH v2] wifi: ath10k: add channel 177 for 5 GHz band

[Kalle Valo]

Paweł Owoc <frut3k7@gmail.com> writes:

> On Fri, Oct 11, 2024 at 6:51 PM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
>>
>> On 10/8/2024 11:49 PM, Paweł Owoc wrote:> Add support for channel 177 (5885
>> MHz ) for the 5 GHz band.
>> >
>> > Tested-on: qca988x hw2.0 firmware ver 10.2.4-1.0-00047
>>
>> Can you elaborate on what was tested in your commit text? And more
>> importantly, what is the impact on existing devices, especially given that
>> existing devices would not have calibration data for this channel in the board
>> files? Does the QCA988x board file even have calibration data for this channel?
>>
> In the case of ath10k we use an external regulatory database.
> For the country "US" channels 169, 173 and 177 are marked as NO-IR and
> we cannot run AP on them.
> Even if channels are not disabled in the board files:
>             * 5845.0 MHz [169] (27.0 dBm) (no IR)
>             * 5865.0 MHz [173] (27.0 dBm) (no IR)
>             * 5885.0 MHz [177] (27.0 dBm) (no IR)
>
> I only tested the use as a client on channel 177:
> root@OpenWrt:~# iwinfo phy1 scan
> Cell 01 - Address: XX:XX:XX:XX:XX:XX
>           ESSID: "ch177"
>           Mode: Master  Frequency: 5.885 GHz  Band: 5 GHz  Channel: 177
>           Signal: -43 dBm  Quality: 67/70
>           Encryption: mixed WPA2/WPA3 PSK/SAE (CCMP)
>           HT Operation:
>                     Primary Channel: 177
>                     Secondary Channel Offset: no secondary
>                     Channel Width: 20 MHz

I wonder how this works with QCA6174, unfortunately I'm not able to test
that.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH v2] wifi: ath10k: add channel 177 for 5 GHz band

[Paweł Owoc]

On Fri, Oct 18, 2024 at 1:49 PM Kalle Valo <kvalo@kernel.org> wrote:
>
> I wonder how this works with QCA6174, unfortunately I'm not able to test
> that.
>
I only tested on QCA988X, QCA9984 and IPQ4019 as clients.
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH v2] wifi: ath10k: add channel 177 for 5 GHz band

[Paweł Owoc]

The changes are added in the ath10k-ct driver:
https://github.com/greearb/ath10k-ct/commit/8f2254b8e0554e78efcef5fb752be0eb3573d281
Is there a chance they will be accepted here as well?