From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: James Prestwood <prestwoj@gmail.com>,
<linux-wireless@vger.kernel.org>,
"ath11k@lists.infradead.org" <ath11k@lists.infradead.org>
Subject: Re: Can ath11k automatically enable CRYPTO_MICHAEL_MIC?
Date: Mon, 13 Nov 2023 17:11:14 +0200 [thread overview]
Message-ID: <87edgtu1rh.fsf@kernel.org> (raw)
In-Reply-To: <b2a44dc4-f5ec-46fe-a4ce-a2151ac65aa3@quicinc.com> (Jeff Johnson's message of "Wed, 8 Nov 2023 06:39:14 -0800")
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 11/8/2023 6:33 AM, James Prestwood wrote:
>> Hi,
>> I'm not very familiar with how the Kconfig stuff works, but I spent
>> longer than I care to admit trying to get the ath11k support to show
>> up in menuconfig.
>> The issue was CONFIG_CRYPT_MICHAEL_MIC was not set, which removed
>> the ath11k driver from menuconfig because of:
>> depends on CRYPTO_MICHAEL_MIC
>> Maybe there was a good reason (again, I don't know much about
>> Kconfig), but should/could this use "select" to automatically enable
>> CRYPTO_MICHAEL_MIC?
>> Thanks,
>> James
>
> + ath11k list to see if there is any history on this topic
I checked the history and this dependency was added by commit
243874c64c81 ("ath11k: handle RX fragments") back in 2020, the commit
message doesn't specify why 'depends on' was used instead of 'select'.
Further investigation shows that ath11k and ath12k are the only who use
'depends on' with CRYPTO_MICHAEL_MIC:
./drivers/net/wireless/intel/ipw2x00/Kconfig: select CRYPTO_MICHAEL_MIC
./drivers/net/wireless/intersil/hostap/Kconfig: select CRYPTO_MICHAEL_MIC
./drivers/net/wireless/intersil/orinoco/Kconfig: select CRYPTO_MICHAEL_MIC
./drivers/net/wireless/ath/ath11k/Kconfig: depends on CRYPTO_MICHAEL_MIC
./drivers/net/wireless/ath/ath12k/Kconfig: depends on CRYPTO_MICHAEL_MIC
./drivers/staging/rtl8192e/Kconfig: select CRYPTO_MICHAEL_MIC
./drivers/staging/ks7010/Kconfig: select CRYPTO_MICHAEL_MIC
So switching ath11k and ath12k to use 'select' should be the best thing
to do. Patches welcome :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-11-13 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 14:33 Can ath11k automatically enable CRYPTO_MICHAEL_MIC? James Prestwood
2023-11-08 14:39 ` Jeff Johnson
2023-11-13 15:11 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edgtu1rh.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=prestwoj@gmail.com \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).