From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A99EC5DF60 for ; Tue, 5 Nov 2019 15:40:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD1362087E for ; Tue, 5 Nov 2019 15:40:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b="hB7nIsB5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389867AbfKEPkJ (ORCPT ); Tue, 5 Nov 2019 10:40:09 -0500 Received: from mail.toke.dk ([52.28.52.200]:35505 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389799AbfKEPkI (ORCPT ); Tue, 5 Nov 2019 10:40:08 -0500 X-Greylist: delayed 422 seconds by postgrey-1.27 at vger.kernel.org; Tue, 05 Nov 2019 10:40:08 EST From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1572967984; bh=xAHDL82gecPwNtpcLYvqhCOsdaSg4bYDDeWK4hm2RNE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hB7nIsB5fZ+6bljmrku1+t0+LeQzWR7H4d6EZeKDuKZQKcV4Vo3O7u3mHI0NAmAyR MWnIM6tnA/oyfnTW6V+3eEKBkqCeT/ipZPP/N0ew9sgVl/6XibHQks0x0Hz3tRcpat ExheoZc7nrPMCtDyvoOzxLwkZHRNUwIbiTRvrbSg1xTFgpYK2BVmBGPXkxxHpWxkWA XwesXWDTqqOC6L8yfFi4u1NdK+bPiy3CS/wMows7EBi8KPmqkYr3Rnnub11c8K2nv3 8NBJ7R/W9+LeY0B/wcUzDMPezA6U9IyM0c7t+aq1XHIkz9jQAnsIaUK8R7FYbgJRYZ sovsHYS6c35YA== To: Johannes Berg , linux-wireless@vger.kernel.org Cc: Johannes Berg Subject: Re: [PATCH] mac80211: fix ieee80211_txq_setup_flows() failure path In-Reply-To: <20191105154110.1ccf7112ba5d.I0ba865792446d051867b33153be65ce6b063d98c@changeid> References: <20191105154110.1ccf7112ba5d.I0ba865792446d051867b33153be65ce6b063d98c@changeid> Date: Tue, 05 Nov 2019 16:33:02 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87eeymjq35.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg writes: > From: Johannes Berg > > If ieee80211_txq_setup_flows() fails, we don't clean up LED > state properly, leading to crashes later on, fix that. > > Fixes: dc8b274f0952 ("mac80211: Move up init of TXQs") > Signed-off-by: Johannes Berg Oops, my bad; thanks for the fix! Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen