From: Kalle Valo <kvalo@codeaurora.org>
To: Zhiwei Jiang <qq282012236@gmail.com>
Cc: ath9k-devel@qca.qualcomm.com, davem@davemloft.net,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath: move spin_lock_bh to spin_lock in tasklet
Date: Tue, 22 Jan 2019 18:42:39 +0200 [thread overview]
Message-ID: <87ef94myo0.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20190122163033.51095-1-qq282012236@gmail.com> (Zhiwei Jiang's message of "Wed, 23 Jan 2019 00:30:33 +0800")
Zhiwei Jiang <qq282012236@gmail.com> writes:
> as you are already in a tasklet, it is unnecessary to call
> spin_lock_bh, because softirq already disable BH.
>
> Signed-off-by: Zhiwei Jiang <qq282012236@gmail.com>
If you post a new version you should mark it as "v2":
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing
No need to resend now but please keep in mind in the future.
--
Kalle Valo
next prev parent reply other threads:[~2019-01-22 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 16:30 [PATCH] ath: move spin_lock_bh to spin_lock in tasklet Zhiwei Jiang
2019-01-22 16:42 ` Kalle Valo [this message]
[not found] ` <CANHzP_uiEoYaSg4fC1gHHjc=gRLjaxt8S3=p6a-rkg5-WjR7MA@mail.gmail.com>
2019-01-23 4:25 ` Kalle Valo
2019-02-07 15:01 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2019-01-19 10:55 Zhiwei Jiang
2019-01-22 12:59 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef94myo0.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qq282012236@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).