From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([52.28.52.200]:49523 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753339AbeEIJgZ (ORCPT ); Wed, 9 May 2018 05:36:25 -0400 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg , Kalle Valo Cc: kbuild test robot , kbuild-all@01.org, linux-wireless@vger.kernel.org, Maya Erez Subject: Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes In-Reply-To: <1525856418.6910.6.camel@sipsolutions.net> References: <201805090154.h4Cokbx2%fengguang.wu@intel.com> <87efil2p2o.fsf@purkki.adurom.net> <1525855900.6910.5.camel@sipsolutions.net> <87tvrhw6kj.fsf@kamboji.qca.qualcomm.com> <1525856418.6910.6.camel@sipsolutions.net> Date: Wed, 09 May 2018 11:36:23 +0200 Message-ID: <87efil41d4.fsf@toke.dk> (sfid-20180509_113630_717857_AEDF5A52) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Johannes Berg writes: > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote: >> Johannes Berg writes: >> >> > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote: >> > > >> > > I guess these warnings come because Toke's patch increased size of >> > > struct cfg80211_tid_stats (which is included in struct station_info) and >> > > both wil6210 and qtnfmac allocate a struct station_info from stack? >> > >> > Yes. >> > >> > > Can >> > > someone send a fix for the drivers? >> > >> > I guess Toke/I should do that through my tree. >> >> IMHO the fix could go through my tree as well, less risk of conflicts in >> drivers. AFAICS the fix (allocating station_info dynamically?) would not >> depend on Toke's patch and could be applied separately. > > That's true, if you prefer that it's fine with me. I'll send a patch. What's the right tag to put in the commit for this? Fixes-but-is-independent-from: ? ;) -Toke