[mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 5146 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
head:   57c6cb81717f957fb741f2e4c79bd0e2f4f55910
commit: 52539ca89f365d3db530535fbffa88a3cca4d2ec [12/14] cfg80211: Expose TXQ stats and parameters to userspace
config: i386-randconfig-i1-201818 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        git checkout 52539ca89f365d3db530535fbffa88a3cca4d2ec
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/net//wireless/ath/wil6210/debugfs.c: In function 'wil_link_debugfs_show':
>> drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    }
    ^
--
   drivers/net//wireless/ath/wil6210/wmi.c: In function 'wmi_evt_connect':
>> drivers/net//wireless/ath/wil6210/wmi.c:979:1: warning: the frame size of 1684 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    }
    ^
--
   drivers/net//wireless/quantenna/qtnfmac/event.c: In function 'qtnf_event_handle_sta_assoc':
>> drivers/net//wireless/quantenna/qtnfmac/event.c:107:1: warning: the frame size of 1616 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    }
    ^

vim +1245 drivers/net//wireless/ath/wil6210/debugfs.c

9eb82d43 Vladimir Kondratiev 2014-06-16  1198  
9eb82d43 Vladimir Kondratiev 2014-06-16  1199  /*---------link------------*/
9eb82d43 Vladimir Kondratiev 2014-06-16  1200  static int wil_link_debugfs_show(struct seq_file *s, void *data)
9eb82d43 Vladimir Kondratiev 2014-06-16  1201  {
9eb82d43 Vladimir Kondratiev 2014-06-16  1202  	struct wil6210_priv *wil = s->private;
9eb82d43 Vladimir Kondratiev 2014-06-16  1203  	struct station_info sinfo;
9eb82d43 Vladimir Kondratiev 2014-06-16  1204  	int i, rc;
9eb82d43 Vladimir Kondratiev 2014-06-16  1205  
9eb82d43 Vladimir Kondratiev 2014-06-16  1206  	for (i = 0; i < ARRAY_SIZE(wil->sta); i++) {
9eb82d43 Vladimir Kondratiev 2014-06-16  1207  		struct wil_sta_info *p = &wil->sta[i];
9eb82d43 Vladimir Kondratiev 2014-06-16  1208  		char *status = "unknown";
5bd60982 Lior David          2018-02-26  1209  		struct wil6210_vif *vif;
5bd60982 Lior David          2018-02-26  1210  		u8 mid;
8fe59627 Vladimir Kondratiev 2014-09-10  1211  
9eb82d43 Vladimir Kondratiev 2014-06-16  1212  		switch (p->status) {
9eb82d43 Vladimir Kondratiev 2014-06-16  1213  		case wil_sta_unused:
9eb82d43 Vladimir Kondratiev 2014-06-16  1214  			status = "unused   ";
9eb82d43 Vladimir Kondratiev 2014-06-16  1215  			break;
9eb82d43 Vladimir Kondratiev 2014-06-16  1216  		case wil_sta_conn_pending:
9eb82d43 Vladimir Kondratiev 2014-06-16  1217  			status = "pending  ";
9eb82d43 Vladimir Kondratiev 2014-06-16  1218  			break;
9eb82d43 Vladimir Kondratiev 2014-06-16  1219  		case wil_sta_connected:
9eb82d43 Vladimir Kondratiev 2014-06-16  1220  			status = "connected";
9eb82d43 Vladimir Kondratiev 2014-06-16  1221  			break;
9eb82d43 Vladimir Kondratiev 2014-06-16  1222  		}
5bd60982 Lior David          2018-02-26  1223  		mid = (p->status != wil_sta_unused) ? p->mid : U8_MAX;
5bd60982 Lior David          2018-02-26  1224  		seq_printf(s, "[%d][MID %d] %pM %s\n",
5bd60982 Lior David          2018-02-26  1225  			   i, mid, p->addr, status);
9eb82d43 Vladimir Kondratiev 2014-06-16  1226  
5bd60982 Lior David          2018-02-26  1227  		if (p->status != wil_sta_connected)
5bd60982 Lior David          2018-02-26  1228  			continue;
5bd60982 Lior David          2018-02-26  1229  
5bd60982 Lior David          2018-02-26  1230  		vif = (mid < wil->max_vifs) ? wil->vifs[mid] : NULL;
5bd60982 Lior David          2018-02-26  1231  		if (vif) {
e00243fa Lior David          2018-02-26  1232  			rc = wil_cid_fill_sinfo(vif, i, &sinfo);
9eb82d43 Vladimir Kondratiev 2014-06-16  1233  			if (rc)
9eb82d43 Vladimir Kondratiev 2014-06-16  1234  				return rc;
9eb82d43 Vladimir Kondratiev 2014-06-16  1235  
9eb82d43 Vladimir Kondratiev 2014-06-16  1236  			seq_printf(s, "  Tx_mcs = %d\n", sinfo.txrate.mcs);
9eb82d43 Vladimir Kondratiev 2014-06-16  1237  			seq_printf(s, "  Rx_mcs = %d\n", sinfo.rxrate.mcs);
9eb82d43 Vladimir Kondratiev 2014-06-16  1238  			seq_printf(s, "  SQ     = %d\n", sinfo.signal);
5bd60982 Lior David          2018-02-26  1239  		} else {
5bd60982 Lior David          2018-02-26  1240  			seq_puts(s, "  INVALID MID\n");
9eb82d43 Vladimir Kondratiev 2014-06-16  1241  		}
9eb82d43 Vladimir Kondratiev 2014-06-16  1242  	}
9eb82d43 Vladimir Kondratiev 2014-06-16  1243  
9eb82d43 Vladimir Kondratiev 2014-06-16  1244  	return 0;
9eb82d43 Vladimir Kondratiev 2014-06-16 @1245  }
9eb82d43 Vladimir Kondratiev 2014-06-16  1246  

:::::: The code at line 1245 was first introduced by commit
:::::: 9eb82d43da0618f6bab78de0f18e7405085dd955 wil6210: add 'freq' and 'link' debugfs entries

:::::: TO: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
:::::: CC: John W. Linville <linville@tuxdriver.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33856 bytes --]

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Kalle Valo]

(adding Maya)

kbuild test robot <lkp@intel.com> writes:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
> head:   57c6cb81717f957fb741f2e4c79bd0e2f4f55910
> commit: 52539ca89f365d3db530535fbffa88a3cca4d2ec [12/14] cfg80211: Expose TXQ stats and parameters to userspace
> config: i386-randconfig-i1-201818 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>         git checkout 52539ca89f365d3db530535fbffa88a3cca4d2ec
>         # save the attached .config to linux build tree
>         make ARCH=i386 
>
> All warnings (new ones prefixed by >>):
>
>    drivers/net//wireless/ath/wil6210/debugfs.c: In function 'wil_link_debugfs_show':
>>> drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>     }
>     ^
> --
>    drivers/net//wireless/ath/wil6210/wmi.c: In function 'wmi_evt_connect':
>>> drivers/net//wireless/ath/wil6210/wmi.c:979:1: warning: the frame size of 1684 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>     }
>     ^
> --
>    drivers/net//wireless/quantenna/qtnfmac/event.c: In function 'qtnf_event_handle_sta_assoc':
>>> drivers/net//wireless/quantenna/qtnfmac/event.c:107:1: warning: the frame size of 1616 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>     }
>     ^

I guess these warnings come because Toke's patch increased size of
struct cfg80211_tid_stats (which is included in struct station_info) and
both wil6210 and qtnfmac allocate a struct station_info from stack? Can
someone send a fix for the drivers?

-- 
Kalle Valo

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Johannes Berg]

On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
> 
> I guess these warnings come because Toke's patch increased size of
> struct cfg80211_tid_stats (which is included in struct station_info) and
> both wil6210 and qtnfmac allocate a struct station_info from stack? 

Yes.

> Can
> someone send a fix for the drivers?

I guess Toke/I should do that through my tree.

johannes

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Kalle Valo]

Johannes Berg <johannes@sipsolutions.net> writes:

> On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>> 
>> I guess these warnings come because Toke's patch increased size of
>> struct cfg80211_tid_stats (which is included in struct station_info) and
>> both wil6210 and qtnfmac allocate a struct station_info from stack? 
>
> Yes.
>
>> Can
>> someone send a fix for the drivers?
>
> I guess Toke/I should do that through my tree.

IMHO the fix could go through my tree as well, less risk of conflicts in
drivers. AFAICS the fix (allocating station_info dynamically?) would not
depend on Toke's patch and could be applied separately.

-- 
Kalle Valo

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Johannes Berg]

On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
> 
> > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
> > > 
> > > I guess these warnings come because Toke's patch increased size of
> > > struct cfg80211_tid_stats (which is included in struct station_info) and
> > > both wil6210 and qtnfmac allocate a struct station_info from stack? 
> > 
> > Yes.
> > 
> > > Can
> > > someone send a fix for the drivers?
> > 
> > I guess Toke/I should do that through my tree.
> 
> IMHO the fix could go through my tree as well, less risk of conflicts in
> drivers. AFAICS the fix (allocating station_info dynamically?) would not
> depend on Toke's patch and could be applied separately.

That's true, if you prefer that it's fine with me.

johannes

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Toke Høiland-Jørgensen]

Johannes Berg <johannes@sipsolutions.net> writes:

> On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>> 
>> > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>> > > 
>> > > I guess these warnings come because Toke's patch increased size of
>> > > struct cfg80211_tid_stats (which is included in struct station_info) and
>> > > both wil6210 and qtnfmac allocate a struct station_info from stack? 
>> > 
>> > Yes.
>> > 
>> > > Can
>> > > someone send a fix for the drivers?
>> > 
>> > I guess Toke/I should do that through my tree.
>> 
>> IMHO the fix could go through my tree as well, less risk of conflicts in
>> drivers. AFAICS the fix (allocating station_info dynamically?) would not
>> depend on Toke's patch and could be applied separately.
>
> That's true, if you prefer that it's fine with me.

I'll send a patch.

What's the right tag to put in the commit for this?
Fixes-but-is-independent-from: ? ;)

-Toke

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Johannes Berg]

On Wed, 2018-05-09 at 11:36 +0200, Toke Høiland-Jørgensen wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
> 
> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
> > > Johannes Berg <johannes@sipsolutions.net> writes:
> > > 
> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
> > > > > 
> > > > > I guess these warnings come because Toke's patch increased size of
> > > > > struct cfg80211_tid_stats (which is included in struct station_info) and
> > > > > both wil6210 and qtnfmac allocate a struct station_info from stack? 
> > > > 
> > > > Yes.
> > > > 
> > > > > Can
> > > > > someone send a fix for the drivers?
> > > > 
> > > > I guess Toke/I should do that through my tree.
> > > 
> > > IMHO the fix could go through my tree as well, less risk of conflicts in
> > > drivers. AFAICS the fix (allocating station_info dynamically?) would not
> > > depend on Toke's patch and could be applied separately.
> > 
> > That's true, if you prefer that it's fine with me.
> 
> I'll send a patch.
> 
> What's the right tag to put in the commit for this?
> Fixes-but-is-independent-from: ? ;)

Heh. You can still put Fixes: I think.

johannes

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Kalle Valo]

Johannes Berg <johannes@sipsolutions.net> writes:

> On Wed, 2018-05-09 at 11:36 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>=20
>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>> > > Johannes Berg <johannes@sipsolutions.net> writes:
>> > >=20
>> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>> > > > >=20
>> > > > > I guess these warnings come because Toke's patch increased size =
of
>> > > > > struct cfg80211_tid_stats (which is included in struct station_i=
nfo) and
>> > > > > both wil6210 and qtnfmac allocate a struct station_info from sta=
ck?=20
>> > > >=20
>> > > > Yes.
>> > > >=20
>> > > > > Can
>> > > > > someone send a fix for the drivers?
>> > > >=20
>> > > > I guess Toke/I should do that through my tree.
>> > >=20
>> > > IMHO the fix could go through my tree as well, less risk of conflict=
s in
>> > > drivers. AFAICS the fix (allocating station_info dynamically?) would=
 not
>> > > depend on Toke's patch and could be applied separately.
>> >=20
>> > That's true, if you prefer that it's fine with me.
>>=20
>> I'll send a patch.
>>=20
>> What's the right tag to put in the commit for this?
>> Fixes-but-is-independent-from: ? ;)
>
> Heh. You can still put Fixes: I think.

Yeah, I think so too.

--=20
Kalle Valo

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Toke Høiland-Jørgensen]

Kalle Valo <kvalo@codeaurora.org> writes:

> Johannes Berg <johannes@sipsolutions.net> writes:
>
>> On Wed, 2018-05-09 at 11:36 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrot=
e:
>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>=20
>>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>>> > > Johannes Berg <johannes@sipsolutions.net> writes:
>>> > >=20
>>> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>>> > > > >=20
>>> > > > > I guess these warnings come because Toke's patch increased size=
 of
>>> > > > > struct cfg80211_tid_stats (which is included in struct station_=
info) and
>>> > > > > both wil6210 and qtnfmac allocate a struct station_info from st=
ack?=20
>>> > > >=20
>>> > > > Yes.
>>> > > >=20
>>> > > > > Can
>>> > > > > someone send a fix for the drivers?
>>> > > >=20
>>> > > > I guess Toke/I should do that through my tree.
>>> > >=20
>>> > > IMHO the fix could go through my tree as well, less risk of conflic=
ts in
>>> > > drivers. AFAICS the fix (allocating station_info dynamically?) woul=
d not
>>> > > depend on Toke's patch and could be applied separately.
>>> >=20
>>> > That's true, if you prefer that it's fine with me.
>>>=20
>>> I'll send a patch.
>>>=20
>>> What's the right tag to put in the commit for this?
>>> Fixes-but-is-independent-from: ? ;)
>>
>> Heh. You can still put Fixes: I think.
>
> Yeah, I think so too.

Cool. My "git grep 'struct station_info sinfo'" also shows up a driver
in staging; that should be fixed as well, right? In the same commit?

-Toke

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Kalle Valo]

Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:

> Kalle Valo <kvalo@codeaurora.org> writes:
>
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>
>>> On Wed, 2018-05-09 at 11:36 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wro=
te:
>>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>>=20
>>>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>>>> > > Johannes Berg <johannes@sipsolutions.net> writes:
>>>> > >=20
>>>> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>>>> > > > >=20
>>>> > > > > I guess these warnings come because Toke's patch increased siz=
e of
>>>> > > > > struct cfg80211_tid_stats (which is included in struct station=
_info) and
>>>> > > > > both wil6210 and qtnfmac allocate a struct station_info from s=
tack?=20
>>>> > > >=20
>>>> > > > Yes.
>>>> > > >=20
>>>> > > > > Can
>>>> > > > > someone send a fix for the drivers?
>>>> > > >=20
>>>> > > > I guess Toke/I should do that through my tree.
>>>> > >=20
>>>> > > IMHO the fix could go through my tree as well, less risk of confli=
cts in
>>>> > > drivers. AFAICS the fix (allocating station_info dynamically?) wou=
ld not
>>>> > > depend on Toke's patch and could be applied separately.
>>>> >=20
>>>> > That's true, if you prefer that it's fine with me.
>>>>=20
>>>> I'll send a patch.
>>>>=20
>>>> What's the right tag to put in the commit for this?
>>>> Fixes-but-is-independent-from: ? ;)
>>>
>>> Heh. You can still put Fixes: I think.
>>
>> Yeah, I think so too.
>
> Cool. My "git grep 'struct station_info sinfo'" also shows up a driver
> in staging; that should be fixed as well, right? In the same commit?

Not in the same commit at least, I don't want to touch staging even with
a ten foot pole :) I guess either Greg or Johannes would take that
patch.

--=20
Kalle Valo

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Toke Høiland-Jørgensen]

Kalle Valo <kvalo@codeaurora.org> writes:

> Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:
>
>> Kalle Valo <kvalo@codeaurora.org> writes:
>>
>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>
>>>> On Wed, 2018-05-09 at 11:36 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wr=
ote:
>>>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>>>=20
>>>>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>>>>> > > Johannes Berg <johannes@sipsolutions.net> writes:
>>>>> > >=20
>>>>> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>>>>> > > > >=20
>>>>> > > > > I guess these warnings come because Toke's patch increased si=
ze of
>>>>> > > > > struct cfg80211_tid_stats (which is included in struct statio=
n_info) and
>>>>> > > > > both wil6210 and qtnfmac allocate a struct station_info from =
stack?=20
>>>>> > > >=20
>>>>> > > > Yes.
>>>>> > > >=20
>>>>> > > > > Can
>>>>> > > > > someone send a fix for the drivers?
>>>>> > > >=20
>>>>> > > > I guess Toke/I should do that through my tree.
>>>>> > >=20
>>>>> > > IMHO the fix could go through my tree as well, less risk of confl=
icts in
>>>>> > > drivers. AFAICS the fix (allocating station_info dynamically?) wo=
uld not
>>>>> > > depend on Toke's patch and could be applied separately.
>>>>> >=20
>>>>> > That's true, if you prefer that it's fine with me.
>>>>>=20
>>>>> I'll send a patch.
>>>>>=20
>>>>> What's the right tag to put in the commit for this?
>>>>> Fixes-but-is-independent-from: ? ;)
>>>>
>>>> Heh. You can still put Fixes: I think.
>>>
>>> Yeah, I think so too.
>>
>> Cool. My "git grep 'struct station_info sinfo'" also shows up a driver
>> in staging; that should be fixed as well, right? In the same commit?
>
> Not in the same commit at least, I don't want to touch staging even with
> a ten foot pole :) I guess either Greg or Johannes would take that
> patch.

Gotcha, I'll split that out :D

-Toke

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Toke Høiland-Jørgensen]

Kalle Valo <kvalo@codeaurora.org> writes:

> Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:
>
>> Kalle Valo <kvalo@codeaurora.org> writes:
>>
>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>
>>>> On Wed, 2018-05-09 at 11:36 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wr=
ote:
>>>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>>>=20
>>>>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>>>>> > > Johannes Berg <johannes@sipsolutions.net> writes:
>>>>> > >=20
>>>>> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>>>>> > > > >=20
>>>>> > > > > I guess these warnings come because Toke's patch increased si=
ze of
>>>>> > > > > struct cfg80211_tid_stats (which is included in struct statio=
n_info) and
>>>>> > > > > both wil6210 and qtnfmac allocate a struct station_info from =
stack?=20
>>>>> > > >=20
>>>>> > > > Yes.
>>>>> > > >=20
>>>>> > > > > Can
>>>>> > > > > someone send a fix for the drivers?
>>>>> > > >=20
>>>>> > > > I guess Toke/I should do that through my tree.
>>>>> > >=20
>>>>> > > IMHO the fix could go through my tree as well, less risk of confl=
icts in
>>>>> > > drivers. AFAICS the fix (allocating station_info dynamically?) wo=
uld not
>>>>> > > depend on Toke's patch and could be applied separately.
>>>>> >=20
>>>>> > That's true, if you prefer that it's fine with me.
>>>>>=20
>>>>> I'll send a patch.
>>>>>=20
>>>>> What's the right tag to put in the commit for this?
>>>>> Fixes-but-is-independent-from: ? ;)
>>>>
>>>> Heh. You can still put Fixes: I think.
>>>
>>> Yeah, I think so too.
>>
>> Cool. My "git grep 'struct station_info sinfo'" also shows up a driver
>> in staging; that should be fixed as well, right? In the same commit?
>
> Not in the same commit at least, I don't want to touch staging even with
> a ten foot pole :) I guess either Greg or Johannes would take that
> patch.

What about batman-adv and wext-compat? Should I split those out as well?

-Toke

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Kalle Valo]

Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:

> Kalle Valo <kvalo@codeaurora.org> writes:
>
>> Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:
>>
>>> Kalle Valo <kvalo@codeaurora.org> writes:
>>>
>>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>>
>>>>> On Wed, 2018-05-09 at 11:36 +0200, Toke H=C3=B8iland-J=C3=B8rgensen w=
rote:
>>>>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>>>>=20
>>>>>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>>>>>> > > Johannes Berg <johannes@sipsolutions.net> writes:
>>>>>> > >=20
>>>>>> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>>>>>> > > > >=20
>>>>>> > > > > I guess these warnings come because Toke's patch increased s=
ize of
>>>>>> > > > > struct cfg80211_tid_stats (which is included in struct stati=
on_info) and
>>>>>> > > > > both wil6210 and qtnfmac allocate a struct station_info from=
 stack?=20
>>>>>> > > >=20
>>>>>> > > > Yes.
>>>>>> > > >=20
>>>>>> > > > > Can
>>>>>> > > > > someone send a fix for the drivers?
>>>>>> > > >=20
>>>>>> > > > I guess Toke/I should do that through my tree.
>>>>>> > >=20
>>>>>> > > IMHO the fix could go through my tree as well, less risk of conf=
licts in
>>>>>> > > drivers. AFAICS the fix (allocating station_info dynamically?) w=
ould not
>>>>>> > > depend on Toke's patch and could be applied separately.
>>>>>> >=20
>>>>>> > That's true, if you prefer that it's fine with me.
>>>>>>=20
>>>>>> I'll send a patch.
>>>>>>=20
>>>>>> What's the right tag to put in the commit for this?
>>>>>> Fixes-but-is-independent-from: ? ;)
>>>>>
>>>>> Heh. You can still put Fixes: I think.
>>>>
>>>> Yeah, I think so too.
>>>
>>> Cool. My "git grep 'struct station_info sinfo'" also shows up a driver
>>> in staging; that should be fixed as well, right? In the same commit?
>>
>> Not in the same commit at least, I don't want to touch staging even with
>> a ten foot pole :) I guess either Greg or Johannes would take that
>> patch.
>
> What about batman-adv and wext-compat? Should I split those out as well?

So normally I only take patches touching drivers/net/wireless, anything
else has to go via other trees.

--=20
Kalle Valo

Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

[Toke Høiland-Jørgensen]

Kalle Valo <kvalo@codeaurora.org> writes:

> Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:
>
>> Kalle Valo <kvalo@codeaurora.org> writes:
>>
>>> Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:
>>>
>>>> Kalle Valo <kvalo@codeaurora.org> writes:
>>>>
>>>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>>>
>>>>>> On Wed, 2018-05-09 at 11:36 +0200, Toke H=C3=B8iland-J=C3=B8rgensen =
wrote:
>>>>>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>>>>>=20
>>>>>>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>>>>>>> > > Johannes Berg <johannes@sipsolutions.net> writes:
>>>>>>> > >=20
>>>>>>> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>>>>>>> > > > >=20
>>>>>>> > > > > I guess these warnings come because Toke's patch increased =
size of
>>>>>>> > > > > struct cfg80211_tid_stats (which is included in struct stat=
ion_info) and
>>>>>>> > > > > both wil6210 and qtnfmac allocate a struct station_info fro=
m stack?=20
>>>>>>> > > >=20
>>>>>>> > > > Yes.
>>>>>>> > > >=20
>>>>>>> > > > > Can
>>>>>>> > > > > someone send a fix for the drivers?
>>>>>>> > > >=20
>>>>>>> > > > I guess Toke/I should do that through my tree.
>>>>>>> > >=20
>>>>>>> > > IMHO the fix could go through my tree as well, less risk of con=
flicts in
>>>>>>> > > drivers. AFAICS the fix (allocating station_info dynamically?) =
would not
>>>>>>> > > depend on Toke's patch and could be applied separately.
>>>>>>> >=20
>>>>>>> > That's true, if you prefer that it's fine with me.
>>>>>>>=20
>>>>>>> I'll send a patch.
>>>>>>>=20
>>>>>>> What's the right tag to put in the commit for this?
>>>>>>> Fixes-but-is-independent-from: ? ;)
>>>>>>
>>>>>> Heh. You can still put Fixes: I think.
>>>>>
>>>>> Yeah, I think so too.
>>>>
>>>> Cool. My "git grep 'struct station_info sinfo'" also shows up a driver
>>>> in staging; that should be fixed as well, right? In the same commit?
>>>
>>> Not in the same commit at least, I don't want to touch staging even with
>>> a ten foot pole :) I guess either Greg or Johannes would take that
>>> patch.
>>
>> What about batman-adv and wext-compat? Should I split those out as well?
>
> So normally I only take patches touching drivers/net/wireless, anything
> else has to go via other trees.

Right, thought so; will send a series as soon as I've verified that it
compiles :)

-Toke