From: Kalle Valo <kvalo@codeaurora.org>
To: Andres Rodriguez <andresx7@gmail.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
mcgrof@kernel.org, alexdeucher@gmail.com,
ckoenig.leichtzumerken@gmail.com, arend.vanspriel@broadcom.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 9/9] brcmfmac: use request_firmware_nowait2 to load firmware without warnings
Date: Sat, 21 Apr 2018 10:19:42 +0300 [thread overview]
Message-ID: <87efj9f2lt.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <65954790-8579-66ee-9b67-d44e18b4abb3@gmail.com> (Andres Rodriguez's message of "Fri, 20 Apr 2018 15:33:36 -0400")
Andres Rodriguez <andresx7@gmail.com> writes:
>>> + fwctx->nvram_name, fwctx->dev,
>>> + GFP_KERNEL, fwctx,
>>> brcmf_fw_request_nvram_done);
>>> /* pass NULL to nvram callback for bcm47xx fallback */
>>> @@ -547,7 +548,7 @@ int brcmf_fw_get_firmwares_pcie(struct device *dev, u16 flags,
>>> fwctx->domain_nr = domain_nr;
>>> fwctx->bus_nr = bus_nr;
>>> - return request_firmware_nowait(THIS_MODULE, true, code, dev,
>>> + return request_firmware_nowait2(THIS_MODULE, true, false, code, dev,
>>> GFP_KERNEL, fwctx,
>>> brcmf_fw_request_code_done);
>>> }
>>
>> Also the number two in the function name is not really telling anything.
>> I think that something like request_firmware_nowait_nowarn() would be
>> better, even if it's so ugly.
>>
>
> The 2 is meant to signify that this is an new version of the api with
> different parameters.
Ah, I missed that. I didn't have time to review your patches in detail,
just looked at the wireless patches.
> I don't think we need to codify into the name what the new parameters
> mean (mostly because when a 2 version of an api is implemented, usage
> of the original version tends to be discouraged).
Yeah, makes sense now.
--
Kalle Valo
next prev parent reply other threads:[~2018-04-21 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180417153307.3693-1-andresx7@gmail.com>
[not found] ` <20180417153307.3693-9-andresx7@gmail.com>
2018-04-20 10:19 ` [PATCH 8/9] ath10k: use request_firmware_nowarn to load firmware Kalle Valo
[not found] ` <20180417153307.3693-10-andresx7@gmail.com>
2018-04-20 10:26 ` [PATCH 9/9] brcmfmac: use request_firmware_nowait2 to load firmware without warnings Kalle Valo
2018-04-20 19:33 ` Andres Rodriguez
2018-04-21 7:19 ` Kalle Valo [this message]
2018-04-21 8:04 ` Arend van Spriel
2018-04-23 13:54 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efj9f2lt.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=alexdeucher@gmail.com \
--cc=andresx7@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).