Re: [v5 7/8] rsi: add module parameter operating mode

[Kalle Valo <kvalo@codeaurora.org>]

Marcel Holtmann <marcel@holtmann.org> writes:

> Hi Kalle,
>
>>> Operating mode determines the support for other protocols.
>>> This is made as module parameter for better usage.
>>> 
>>> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
>>> Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
>>> Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>
>> 
>> [...]
>> 
>>> +/* Default operating mode is wlan STA + BT */
>>> +static u16 dev_oper_mode = DEV_OPMODE_STA_BT_DUAL;
>>> +module_param(dev_oper_mode, ushort, 0444);
>>> +MODULE_PARM_DESC(dev_oper_mode,
>>> +		 "1[Wi-Fi], 4[BT], 8[BT LE], 5[Wi-Fi STA + BT classic]\n"
>>> +		 "9[Wi-Fi STA + BT LE], 13[Wi-Fi STA + BT classic + BT LE]\n"
>>> +		 "6[AP + BT classic], 14[AP + BT classic + BT LE]");
>> 
>> I really wish that we have nl80211 interface for configuring btcoex. We
>> have been talking about that for years but nobody has implemented it :(
>
> the Bluetooth subsystem and Wireless subsystem can handle that
> perfectly between themselves. Involving userspace is utterly
> pointless. First step should be that the Wireless subsystem has an
> option to inform its actively used frequencies to the Bluetooth
> subsystem. It then could adjust AFP channel mapping.

Yeah, that would be much better.

-- 
Kalle Valo