From: Kalle Valo <kvalo@codeaurora.org>
To: Wright Feng <wright.feng@cypress.com>
Cc: arend.vanspriel@broadcom.com, franky.lin@broadcom.com,
hante.meuleman@broadcom.com, linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
Chi-hsien Lin <Chi-Hsien.Lin@cypress.com>
Subject: Re: [PATCH] brcmfmac: remove setting IBSS mode when stopping AP
Date: Fri, 19 May 2017 07:49:58 +0300 [thread overview]
Message-ID: <87efvla1s9.fsf@codeaurora.org> (raw)
In-Reply-To: <1495099339-7626-1-git-send-email-wright.feng@cypress.com> (Wright Feng's message of "Thu, 18 May 2017 17:22:19 +0800")
Wright Feng <wright.feng@cypress.com> writes:
> From: Chi-hsien Lin <Chi-Hsien.Lin@cypress.com>
>
> Setting IBSS mode when stopping AP may affect functionality of INFRA
> mode on another interface. For instance, if user creates and stops
> hostap daemon on virtual interface, then association cannot work on
> primary interface because default BSS has been set to IBSS mode in
> firmware side. The IBSS mode should be set when cfg80211 changes the
> interface.
>
> Reviewed-by: Wright Feng <wright.feng@cypress.com>
> Signed-off-by: Chi-hsien Lin <Chi-Hsien.Lin@cypress.com>
> Signed-off-by: Wright Feng <wright.feng@cypress.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index 944b83c..ce2a5b6 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -4658,9 +4658,6 @@ static int brcmf_cfg80211_stop_ap(struct wiphy *wiphy, struct net_device *ndev)
> err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_SET_AP, 0);
> if (err < 0)
> brcmf_err("setting AP mode failed %d\n", err);
> - err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_SET_INFRA, 0);
> - if (err < 0)
> - brcmf_err("setting INFRA mode failed %d\n", err);
The title talks about setting IBSS mode but the code looks to be about
setting INFRA mode. Is this correct?
--
Kalle Valo
next prev parent reply other threads:[~2017-05-19 4:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 9:22 [PATCH] brcmfmac: remove setting IBSS mode when stopping AP Wright Feng
2017-05-19 4:49 ` Kalle Valo [this message]
2017-05-19 7:49 ` Arend van Spriel
2017-05-19 7:54 ` Kalle Valo
2017-05-22 15:21 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efvla1s9.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Chi-Hsien.Lin@cypress.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).