From: Kalle Valo <kvalo@codeaurora.org>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: "linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>, "Cathy Luo" <cluo@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>
Subject: Re: [PATCH v3 1/2] mwifiex: add manufacturing mode support
Date: Wed, 13 Jul 2016 19:31:02 +0300 [thread overview]
Message-ID: <87eg6xzeih.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <2dcba20e490840918e80c4f91a250739@SC-EXCH04.marvell.com> (Amitkumar Karwar's message of "Wed, 13 Jul 2016 15:57:15 +0000")
Amitkumar Karwar <akarwar@marvell.com> writes:
> Hi Kalle,
>
>> -----Original Message-----
>> From: Kalle Valo [mailto:kvalo@codeaurora.org]
>> Sent: Wednesday, July 13, 2016 9:20 PM
>> To: Amitkumar Karwar
>> Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam
>> Subject: Re: [PATCH v3 1/2] mwifiex: add manufacturing mode support
>>
>> Amitkumar Karwar <akarwar@marvell.com> writes:
>>
>> > By default normal mode is chosen when driver is loaded. This patch
>> > adds a provision to choose manufacturing mode via module parameters.
>> >
>> > Command to load driver in manufacturing mode insmod mwifiex.ko
>> > mfg_mode=1 and mfg_firmware=mrvl/firmware.
>> >
>> > Tested-by: chunfan chen <jeffc@marvell.com>
>> > Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
>>
>> Why the mfg_firmware module parameter?
>
> It's to specify a firmware name.
Yeah, I got that. But why do you need that? Why not just hardcode the
firmware name in the driver, which is the normal thing to do?
--
Kalle Valo
next prev parent reply other threads:[~2016-07-13 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 13:48 [PATCH v3 1/2] mwifiex: add manufacturing mode support Amitkumar Karwar
2016-07-13 13:48 ` [PATCH v3 2/2] mwifiex: add hostcmd wext ioctl support Amitkumar Karwar
2016-07-13 15:14 ` Kalle Valo
2016-07-13 15:25 ` Amitkumar Karwar
2016-07-13 15:48 ` Kalle Valo
2016-07-13 15:59 ` Amitkumar Karwar
2016-07-16 14:42 ` kbuild test robot
2016-07-13 15:50 ` [PATCH v3 1/2] mwifiex: add manufacturing mode support Kalle Valo
2016-07-13 15:57 ` Amitkumar Karwar
2016-07-13 16:31 ` Kalle Valo [this message]
2016-07-13 16:39 ` Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg6xzeih.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=akarwar@marvell.com \
--cc=cluo@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox