From: Kalle Valo <kvalo@codeaurora.org>
To: "Michael Büsch" <m@bues.ch>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Jia-Ju Bai <baijiaju1990@163.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
joe@perches.com
Subject: Re: [v2, resend] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init
Date: Mon, 14 Mar 2016 08:15:33 +0200 [thread overview]
Message-ID: <87egbdmvp6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20160311173047.785c2b24@wiggum> ("Michael Büsch"'s message of "Fri, 11 Mar 2016 17:30:47 +0100")
Michael Büsch <m@bues.ch> writes:
> On Fri, 11 Mar 2016 21:52:30 +0530
> Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
>
>> On Sat, Jan 16, 2016 at 09:08:10PM +0800, Jia-Ju Bai wrote:
>> > The memory allocated by kzalloc in b43_bus_dev_ssb_init and
>> > b43_bus_dev_bcma_init is not freed.
>> > This patch fixes the bug by adding kfree in b43_ssb_remove,
>> > b43_bcma_remove and error handling code of b43_bcma_probe.
>> >
>> > Thanks Michael for his suggestion.
>> >
>> > Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
>>
>> The patch did not apply cleanly. I had to edit the patch to point to
>> drivers/net/wireless/broadcom/b43/main.c
>>
>> For CONFIG_B43_SSB part-
>> Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>
>
> Ok thanks a lot.
> We possibly don't get an bcma tester anytime soon. As this is quite an
> important fix, we should probably apply it.
>
> Sudip, can you please update the patch so it applies cleanly on the
> current tree? You can add my acked-by if you want.
>
> Kalle, can you please apply it afterwards?
Will do.
--
Kalle Valo
prev parent reply other threads:[~2016-03-14 6:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-16 13:08 [PATCH v2 resend] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init Jia-Ju Bai
2016-01-16 13:13 ` Michael Büsch
2016-01-16 13:17 ` Jia-Ju Bai
2016-03-11 16:22 ` [v2, " Sudip Mukherjee
2016-03-11 16:30 ` Michael Büsch
2016-03-14 6:15 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egbdmvp6.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=b43-dev@lists.infradead.org \
--cc=baijiaju1990@163.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).