From: Kalle Valo <kvalo@codeaurora.org>
To: Arend van Spriel <arend@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Hante Meuleman <meuleman@broadcom.com>
Subject: Re: [PATCH] brcmfmac: fix sdio sg table alloc crash
Date: Tue, 19 Jan 2016 14:55:49 +0200 [thread overview]
Message-ID: <87egdd684q.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1453203564-15974-1-git-send-email-arend@broadcom.com> (Arend van Spriel's message of "Tue, 19 Jan 2016 12:39:24 +0100")
Arend van Spriel <arend@broadcom.com> writes:
> From: Hante Meuleman <meuleman@broadcom.com>
>
> With commit 7d34b0560567 ("brcmfmac: Move all module parameters to
> one place") a bug was introduced causing a null pointer exception.
> This patch fixes the bug by initializing the sg table till after
> the settings have been initialized.
>
> Reported-by: Marc Zyngier <marc.zyngier@arm.com>
> Tested-by: Marc Zyngier <marc.zyngier@arm.com>
> Reviewed-by: Arend Van Spriel <arend@broadcom.com>
> Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
> Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
Thanks, I'm planning to push this to 4.5.
--
Kalle Valo
next prev parent reply other threads:[~2016-01-19 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 11:39 [PATCH] brcmfmac: fix sdio sg table alloc crash Arend van Spriel
2016-01-19 12:55 ` Kalle Valo [this message]
2016-01-19 19:27 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egdd684q.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).