* [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate
[not found] <1450087564-28441-1-git-send-email-a.hajda@samsung.com>
@ 2015-12-14 10:06 ` Andrzej Hajda
2015-12-31 13:12 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Andrzej Hajda @ 2015-12-14 10:06 UTC (permalink / raw)
To: QCA ath9k Development
Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
Kalle Valo, linux-wireless, ath9k-devel, netdev, linux-kernel
The function can return negative values in case of error.
Its result should be then tested for such case.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/net/wireless/ath/ath9k/htc_drv_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
index a680a97..fe1fd1a 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
@@ -834,7 +834,7 @@ void ath9k_htc_ani_work(struct work_struct *work)
if (longcal || shortcal)
common->ani.caldone =
ath9k_hw_calibrate(ah, ah->curchan,
- ah->rxchainmask, longcal);
+ ah->rxchainmask, longcal) > 0;
ath9k_htc_ps_restore(priv);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate
2015-12-14 10:06 ` [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate Andrzej Hajda
@ 2015-12-31 13:12 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2015-12-31 13:12 UTC (permalink / raw)
To: Andrzej Hajda
Cc: QCA ath9k Development, Bartlomiej Zolnierkiewicz,
Marek Szyprowski, linux-wireless, ath9k-devel, netdev,
linux-kernel
Andrzej Hajda <a.hajda@samsung.com> writes:
> The function can return negative values in case of error.
> Its result should be then tested for such case.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Applied to ath.git, thanks.
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-31 13:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1450087564-28441-1-git-send-email-a.hajda@samsung.com>
2015-12-14 10:06 ` [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate Andrzej Hajda
2015-12-31 13:12 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).