From: Kalle Valo <kvalo@codeaurora.org>
To: RUC_Soft_Sec <zy900702@163.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net] Fix error handling in ezusb_probe()
Date: Mon, 21 Sep 2015 13:24:02 +0300 [thread overview]
Message-ID: <87eghsqddp.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <4fb5a5fe.340c.14fe3857f23.Coremail.zy900702@163.com> (RUC Soft Sec's message of "Sat, 19 Sep 2015 10:53:41 +0800 (CST)")
RUC_Soft_Sec <zy900702@163.com> writes:
> Current code assigns 0 to variable 'retval', which makes ezusb_probe()
> to return success even if alloc_orinocodev() fails.
>
> Fix it by checking the return value from alloc_orinocodev() and
> assigns '-ENOMEM' to variable 'retval' in the case of error.
>
>
> Signed-off-by: RUC_Soft_Sec <zy900702@163.com>
Please use your real name both in From header and in Signed-off-by line.
Also use "orinoco_usb:" as the prefix in the commit title.
> ---
> orinoco_usb.c | 1 +
> 1 file changed, 1 insertion(+)
This is wrong, the patch should contain the full source path.
--
Kalle Valo
parent reply other threads:[~2015-09-21 10:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4fb5a5fe.340c.14fe3857f23.Coremail.zy900702@163.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eghsqddp.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zy900702@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).