* Re: [PATCH] [net] Fix error handling in ezusb_probe()
[not found] <4fb5a5fe.340c.14fe3857f23.Coremail.zy900702@163.com>
@ 2015-09-21 10:24 ` Kalle Valo
0 siblings, 0 replies; only message in thread
From: Kalle Valo @ 2015-09-21 10:24 UTC (permalink / raw)
To: RUC_Soft_Sec; +Cc: linux-wireless, netdev, linux-kernel
RUC_Soft_Sec <zy900702@163.com> writes:
> Current code assigns 0 to variable 'retval', which makes ezusb_probe()
> to return success even if alloc_orinocodev() fails.
>
> Fix it by checking the return value from alloc_orinocodev() and
> assigns '-ENOMEM' to variable 'retval' in the case of error.
>
>
> Signed-off-by: RUC_Soft_Sec <zy900702@163.com>
Please use your real name both in From header and in Signed-off-by line.
Also use "orinoco_usb:" as the prefix in the commit title.
> ---
> orinoco_usb.c | 1 +
> 1 file changed, 1 insertion(+)
This is wrong, the patch should contain the full source path.
--
Kalle Valo
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-09-21 10:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4fb5a5fe.340c.14fe3857f23.Coremail.zy900702@163.com>
2015-09-21 10:24 ` [PATCH] [net] Fix error handling in ezusb_probe() Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).