* [PATCH next] bcma: make bcma_host_pci_(up|down) calls safe for every config
@ 2015-03-04 11:14 Rafał Miłecki
2015-03-05 12:12 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2015-03-04 11:14 UTC (permalink / raw)
To: Kalle Valo, linux-wireless
Cc: Hauke Mehrtens, Arnd Bergmann, Rafał Miłecki
We were providing declarations but actual code was compiled only with
CONFIG_BCMA_HOST_PCI set. This could result in:
ERROR: "bcma_host_pci_down" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
ERROR: "bcma_host_pci_up" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
ERROR: "bcma_host_pci_down" [drivers/net/wireless/b43/b43.ko] undefined!
ERROR: "bcma_host_pci_up" [drivers/net/wireless/b43/b43.ko] undefined!
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
include/linux/bcma/bcma.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/include/linux/bcma/bcma.h b/include/linux/bcma/bcma.h
index 037620b..44057b4 100644
--- a/include/linux/bcma/bcma.h
+++ b/include/linux/bcma/bcma.h
@@ -434,8 +434,17 @@ static inline struct bcma_device *bcma_find_core(struct bcma_bus *bus,
return bcma_find_core_unit(bus, coreid, 0);
}
+#ifdef CONFIG_BCMA_HOST_PCI
extern void bcma_host_pci_up(struct bcma_bus *bus);
extern void bcma_host_pci_down(struct bcma_bus *bus);
+#else
+static inline void bcma_host_pci_up(struct bcma_bus *bus)
+{
+}
+static inline void bcma_host_pci_down(struct bcma_bus *bus)
+{
+}
+#endif
extern bool bcma_core_is_enabled(struct bcma_device *core);
extern void bcma_core_disable(struct bcma_device *core, u32 flags);
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] bcma: make bcma_host_pci_(up|down) calls safe for every config
2015-03-04 11:14 [PATCH next] bcma: make bcma_host_pci_(up|down) calls safe for every config Rafał Miłecki
@ 2015-03-05 12:12 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2015-03-05 12:12 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: linux-wireless, Hauke Mehrtens, Arnd Bergmann
Rafał Miłecki <zajec5@gmail.com> writes:
> We were providing declarations but actual code was compiled only with
> CONFIG_BCMA_HOST_PCI set. This could result in:
> ERROR: "bcma_host_pci_down" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
> ERROR: "bcma_host_pci_up" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
> ERROR: "bcma_host_pci_down" [drivers/net/wireless/b43/b43.ko] undefined!
> ERROR: "bcma_host_pci_up" [drivers/net/wireless/b43/b43.ko] undefined!
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Thanks, applied to wireless-drivers-next.git.
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-05 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-04 11:14 [PATCH next] bcma: make bcma_host_pci_(up|down) calls safe for every config Rafał Miłecki
2015-03-05 12:12 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).