From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v2 3/3] ath10k: add cal_data debugfs file
Date: Wed, 24 Sep 2014 14:00:37 +0300 [thread overview]
Message-ID: <87egv18eqy.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=O8j1x-71SCLq9ZiXBU28Ax9M7tyfbvB=mjsWUwgPSjw@mail.gmail.com> (Michal Kazior's message of "Wed, 24 Sep 2014 09:00:39 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 23 September 2014 16:32, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> [...]
>> diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
>> index 101c6f9cf2a8..426341480262 100644
>> --- a/drivers/net/wireless/ath/ath10k/debug.c
>> +++ b/drivers/net/wireless/ath/ath10k/debug.c
> [...]
>> +static int ath10k_cal_data_open(struct inode *inode, struct file *file)
>
> Shouldn't functions in debug.c have ath10k_debug_ prefix? I'm aware
> other fops stuff doesn't include the _debug word as well so this is
> somewhat consistent with the current code but is this okay in the
> grand scheme of things? Just wondering.
IMHO we should use ath10k_debug_ with fops functions as well, I just
haven't been that picky about that.
I'll change this as well and send v3. Thanks for review!
--
Kalle Valo
next prev parent reply other threads:[~2014-09-24 11:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 14:32 [PATCH v2 1/3] ath10k: don't enable interrupts for the diagnostic window Kalle Valo
2014-09-23 14:32 ` [PATCH v2 2/3] ath10k: add diag_read() to hif ops Kalle Valo
2014-09-23 14:32 ` [PATCH v2 3/3] ath10k: add cal_data debugfs file Kalle Valo
2014-09-24 7:00 ` Michal Kazior
2014-09-24 11:00 ` Kalle Valo [this message]
2014-09-23 14:38 ` [PATCH v2 1/3] ath10k: don't enable interrupts for the diagnostic window Kalle Valo
2014-09-24 6:58 ` Michal Kazior
2014-09-24 10:26 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egv18eqy.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).