From: Kalle Valo <kvalo@adurom.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Amitkumar Karwar <akarwar@marvell.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: mwifiex: add firmware dump feature for PCIe
Date: Thu, 24 Apr 2014 11:50:33 +0300 [thread overview]
Message-ID: <87eh0n5cx2.fsf@purkki.adurom.net> (raw)
In-Reply-To: <477F20668A386D41ADCC57781B1F70430F70A2A9EA@SC-VEXCH1.marvell.com> (Bing Zhao's message of "Wed, 23 Apr 2014 14:37:09 -0700")
Bing Zhao <bzhao@marvell.com> writes:
>> The main question is why are we writing to /var and /tmp anyway instead
>> of putting this in debugfs or sysfs?
IMHO no sane wifi driver should _ever_ write anything to a file system.
That's just evil.
> AFAIK, the debugfs or sysfs cannot store/hold the files we retrieve
> from firmware at the scene. We write fw_dump files to rootfs so that
> the files are stored even if the system reboots due to hung_task
> timeout.
Can't you have a user space tool reading the sysfs file and store the
file permanently? That way kernel is not involved in file system access
at all.
--
Kalle Valo
prev parent reply other threads:[~2014-04-24 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 14:30 mwifiex: add firmware dump feature for PCIe Dan Carpenter
2014-04-23 21:37 ` Bing Zhao
2014-04-23 21:47 ` Dan Carpenter
2014-04-24 8:50 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh0n5cx2.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox