From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bartosz Markowski <bartosz.markowski@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] ath10k: implement per-VDEV FW statistics
Date: Fri, 6 Sep 2013 12:48:28 +0300 [thread overview]
Message-ID: <87eh92i8lv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1378196481-13983-3-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Tue, 3 Sep 2013 10:21:21 +0200")
Bartosz Markowski <bartosz.markowski@tieto.com> writes:
> The WMI_REQUEST_PEER_STAT command with latst (1.0.0.716) FW
> can return per-VDEV statistics. Using debugfs we can fetch this info now.
>
> This is a backward compatible change. In case of older FW the VDEV
> statistics are simply not returned.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
> ---
[...]
> for (i = 0; i < num_peer_stats; i++) {
> - peer_stats = (struct wmi_peer_stats *)tmp;
> + peer_stats = (struct wmi_peer_stats_common *)tmp;
You still have the evil cast here :)
(Evil here meaning that that you make the implicit assumption that _v1
and _v2 start with the _common struct.)
Let me send v5 and you can review that before I commit.
--
Kalle Valo
prev parent reply other threads:[~2013-09-06 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 8:21 [PATCH v4 0/2] add per-VDEV FW statistics Bartosz Markowski
2013-09-03 8:21 ` [PATCH v4 1/2] ath10k: update wal_dbg_tx_stats structure with missing parameter Bartosz Markowski
2013-09-03 8:21 ` [PATCH v4 2/2] ath10k: implement per-VDEV FW statistics Bartosz Markowski
2013-09-06 9:48 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh92i8lv.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=bartosz.markowski@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox