Re: [PATCH v3 1/2] ath10k: update wal_dbg_tx_stats structure with missing parameter.

[Kalle Valo <kvalo@qca.qualcomm.com>]

Bartosz Markowski <bartosz.markowski@tieto.com> writes:

> It's very imporatant to keep these structs up to date with FW abi,
> due to the arithmetic we use while read the fw_stats.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
> ---
>  drivers/net/wireless/ath/ath10k/wmi.h |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
> index 08860c4..5b94707 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi.h
> +++ b/drivers/net/wireless/ath/ath10k/wmi.h
> @@ -1767,6 +1767,9 @@ struct wal_dbg_tx_stats {
>  	/* wal pdev resets  */
>  	__le32 pdev_resets;
>  
> +	/* frames dropped due to non-availability of stateless TIDs */
> +	__le32 stateless_tid_alloc_failure;
> +
>  	__le32 phy_underrun;

I still wonder if this needs a feature bit. At least you should mention
in the commit log why it's not needed.

-- 
Kalle Valo