Re: [RFC PATCHv2 1/2] mac80211: Determine dynamic PS timeout based on ps-qos network latency

[Kalle Valo <kvalo@adurom.com>]

Juuso Oikarinen <juuso.oikarinen@nokia.com> writes:

> Determine the dynamic PS timeout based on the configured ps-qos network
> latency. For backwards wext compatibility, allow the dynamic PS timeout
> configured by the cfg80211 to overrule the automatically determined value.

Thanks. I took a quick look, but I haven't tested this yet myself.

> +		timeout = local->hw.conf.dynamic_ps_forced_timeout;
> +		if (timeout < 0) {
> +			if (latency <= 50000)
> +				timeout = 300;
> +			else if (latency <= 2000000000)
> +				timeout = 100;
> +			else
> +				timeout = 0;
> +		}
> +		local->hw.conf.dynamic_ps_timeout = timeout;

What will be the timeout value when there are no pm_qos requirements
from user space applications? Do you know what will be the default
latency value in that case?

I'm mostly worried about timeout 0 case, for example I suspect ath9k
is broken with that value.

Also does this patch change the default value of dynamic ps timeout?

-- 
Kalle Valo