From: Kalle Valo <kvalo@kernel.org>
To: Alexander Wetzel <alexander@wetzel-home.de>
Cc: johannes@sipsolutions.net, nbd@nbd.name,
linux-wireless@vger.kernel.org, Thomas Mann <rauchwolke@gmx.net>,
stable@vger.kernel.org
Subject: Re: [PATCH] wifi: mac80211: Serialize ieee80211_handle_wake_tx_queue()
Date: Wed, 15 Mar 2023 18:47:15 +0200 [thread overview]
Message-ID: <87fsa6vu5o.fsf@kernel.org> (raw)
In-Reply-To: <20230314211122.111688-1-alexander@wetzel-home.de> (Alexander Wetzel's message of "Tue, 14 Mar 2023 22:11:22 +0100")
Alexander Wetzel <alexander@wetzel-home.de> writes:
> ieee80211_handle_wake_tx_queue must not run concurrent multiple times.
> It calls ieee80211_txq_schedule_start() and the drivers migrated to iTXQ
> do not expect overlapping drv_tx() calls.
>
> This fixes 'c850e31f79f0 ("wifi: mac80211: add internal handler for
> wake_tx_queue")', which introduced ieee80211_handle_wake_tx_queue.
> Drivers started to use it with 'a790cc3a4fad ("wifi: mac80211: add
> wake_tx_queue callback to drivers")'.
> But only after fixing an independent bug with
> '4444bc2116ae ("wifi: mac80211: Proper mark iTXQs for resumption")'
> problematic concurrent calls really happened and exposed the initial
> issue.
This is cosmetics but the recommended way to refer to commits is:
This fixes commit c850e31f79f0 ("wifi: mac80211: add internal handler
for wake_tx_queue"), which introduced ieee80211_handle_wake_tx_queue....
More info:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-03-15 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 21:11 [PATCH] wifi: mac80211: Serialize ieee80211_handle_wake_tx_queue() Alexander Wetzel
2023-03-14 21:55 ` Felix Fietkau
2023-03-15 16:47 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsa6vu5o.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=alexander@wetzel-home.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=rauchwolke@gmx.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).